From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-136371-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 120257 invoked by alias); 20 Jan 2017 19:17:05 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 120175 invoked by uid 89); 20 Jan 2017 19:16:59 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Jan 2017 19:16:59 +0000
Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203])	by relay1.mentorg.com with esmtp 	id 1cUegD-0000iD-3y from Luis_Gustavo@mentor.com ; Fri, 20 Jan 2017 11:16:57 -0800
Received: from [172.30.9.36] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 20 Jan 2017 11:16:54 -0800
Reply-To: Luis Machado <lgustavo@codesourcery.com>
Subject: Re: [PATCH] Make gdb.python/python.exp more robust
References: <1484923030-16656-1-git-send-email-lgustavo@codesourcery.com> <2899cd10-7498-6b56-c53b-f2eb1f87e5fa@redhat.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
From: Luis Machado <lgustavo@codesourcery.com>
Message-ID: <fcb67107-e1c8-2445-d006-f8fe2ea1c64b@codesourcery.com>
Date: Fri, 20 Jan 2017 19:17:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <2899cd10-7498-6b56-c53b-f2eb1f87e5fa@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203)
X-IsSubscribed: yes
X-SW-Source: 2017-01/txt/msg00427.txt.bz2

On 01/20/2017 10:59 AM, Pedro Alves wrote:
> On 01/20/2017 02:37 PM, Luis Machado wrote:
>
>>  }
>>  gdb_test "python print (symtab\[1\]\[0\].symtab)" ".*${python_1_c}" "test decode_line func1 filename"
>> -gdb_test "python print (symtab\[1\]\[0\].line)" "19" "test decode_line func1 line number"
>> +
>> +# Fetch the line GDB thinks func1 starts at.  This may change depending
>> +# on the architecture and on how GDB handles the prologue of the function.
>> +gdb_test_multiple "info line func1" "info line func1" {
>> +    -re "Line ($decimal) of .* starts at address $hex <func1> and ends at $hex <func1\\+$decimal>\.\[\r\n\]+$gdb_prompt $" {
>> +	# Fetch the line number.
>> +	set func1_lineno $expect_out(1,string)
>> +    }
>> +}
>
> Do:
>
>   set func1_lineno "noline"
>

Indeed.

> before gdb_test_multiple, so that in case the above FAILs, this:
>
>> +
>> +gdb_test "python print (symtab\[1\]\[0\].line)" "$func1_lineno" "test decode_line func1 line number"
>
> FAILs too, instead of ERRORing out with a TCL error, due to
> undefined $func1_lineno.
>
> OK with that change.
>
> Thanks,
> Pedro Alves
>
>

Fixed and pushed as d334ae250a3ec888f0603cf8e909d0f425aeb30f.

Thanks,
Luis