From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id BQ0wBCQZmWlIggMAWB0awg (envelope-from ) for ; Fri, 20 Feb 2026 21:32:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1771641123; bh=LXrcM8Y+Y9NAhj7kihPr3CYQ+8z/lwyAyD55Lsg+fNY=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VmFAS9codAPioM8bMz1NBwUQCmhdd3Kln1HASM7L4qfR0l7vTc4GWLNg5lum6y801 gijw/e//lwTZ2uCqUK4TLzuuPuCChnuM20Cu/0e1vuOFyTyxmYBRlbc8YKgjxWsMXb tjeW/xn+AwQgxKTpEqJVnCa8hkDAMTf+hXRwJ8DE= Received: by simark.ca (Postfix, from userid 112) id F143E1E08D; Fri, 20 Feb 2026 21:32:03 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=VK9KC6pZ; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 86AAC1E08D for ; Fri, 20 Feb 2026 21:32:03 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id EA3B24BAD14E for ; Sat, 21 Feb 2026 02:32:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EA3B24BAD14E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=VK9KC6pZ Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 5BD944B9DB66 for ; Sat, 21 Feb 2026 02:31:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5BD944B9DB66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5BD944B9DB66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771641098; cv=none; b=sN6oIF2EBeuaZlM8/iP77ZiIP/pa/aIJ8xzwS6mJ48Gyq9H744+DiZ1U6qp/PfdEkVgoX/VQp9N5c8YNgiYYoNXlGDet0wUMnDqm1njTEw6zdmZI6mZq1eEqH0BC35XF6sLtXkTyNU0RAndkZ5pV+XmaKeSpxDw2KwPPZQ4wc70= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771641098; c=relaxed/simple; bh=LXrcM8Y+Y9NAhj7kihPr3CYQ+8z/lwyAyD55Lsg+fNY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=C/vntpuoT4aYjDngrGWQvNTkp3O5szHt763kXf+/KOvYMFqtA1HoHnXId3xv0Rqgecs8myfXtXai9y6JYJQi/Aj3mTd4lVbunswMppgmar04X5mfjkrwbTxUMWmJVcRT2zdm0whuWUUVZ0tJBygzVMhcOIeOKYJx9HWTJ9Pdqzg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5BD944B9DB66 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1771641097; bh=LXrcM8Y+Y9NAhj7kihPr3CYQ+8z/lwyAyD55Lsg+fNY=; h=Date:Subject:To:References:From:In-Reply-To:From; b=VK9KC6pZTaQmzojdxgbWTGwGKo/FpLhCm0Gb+3pQP0fBKAnDRwibVbAqsUeVTMy4Z Kh/F1HSh7NgZlRmpP2l8zNxXt8UEcjWdE/eB/k+OKRqYPWTbOiPn2ebgcM3unc3SkP TmT1IDNSQYrSNOzkcojSxsAYAmmM14osabd2yWWc= Received: by simark.ca (Postfix) id D1F311E08D; Fri, 20 Feb 2026 21:31:36 -0500 (EST) Message-ID: Date: Fri, 20 Feb 2026 21:31:36 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/10] Mildly better refcount safety for Python To: Tom Tromey , gdb-patches@sourceware.org References: <20260220-python-safety-minor-v1-0-4c4b12e445af@adacore.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20260220-python-safety-minor-v1-0-4c4b12e445af@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-02-20 16:03, Tom Tromey wrote: > This series converts a number of gdb-to-Python converion functions to > return a gdbpy_ref<> rather than returning a PyObject* and then simply > documenting that a new reference is returned. > > The hope is that this will make refcount mistakes less likely. > > Regression tested on x86-64 Fedora 43. > > Signed-off-by: Tom Tromey I don't know if someone else wants to review this, but I think this is good. I think it's good if the references are managed from the point where we get them from the Python API to the point where we release them to the Python API. I gave it a quick look, since it's very mechanical and I probably wouldn't spot mistakes anyway. But I asked Claude to review and it said it looked good. It even noted that you fixed a ref leak in the symbol patch. Approved-By: Simon Marchi Simon