From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17423 invoked by alias); 7 Jun 2016 14:03:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17412 invoked by uid 89); 7 Jun 2016 14:03:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=symbol's, guideline, intends, convey X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 07 Jun 2016 14:03:41 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ACE0D80B20; Tue, 7 Jun 2016 14:03:40 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u57E3bN7000650; Tue, 7 Jun 2016 10:03:37 -0400 Subject: Re: [RFA 3/3] Move logic out of symbol_find_demangled_name To: Yao Qi , Tom Tromey References: <1465051760-25840-1-git-send-email-tom@tromey.com> <1465051760-25840-4-git-send-email-tom@tromey.com> <86mvmywgj1.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Tue, 07 Jun 2016 14:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <86mvmywgj1.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-06/txt/msg00133.txt.bz2 On 06/06/2016 03:14 PM, Yao Qi wrote: > Tom Tromey writes: > >> > I'm not especially fond of the new name, "la_demangle_for_symbol". >> > > How about "la_sniff_by_symbol"? IMO, symbol_find_demangled_name does > two things, set the language of symbol, and get the demangled name. > It is quite similar to frame unwinder sniffer and frame unwinding. > I have to admit that it took me a bit to understand what the "by" meant, but I think it intends to convey: "sniff the symbol's language from the symbol's mangled name". So s/by symbol/from symbol/ would be better, IMHO. symbol_find_demangled_name says: /* (...) attempt to find any demangling algorithm that works and then set the language appropriately. The returned name is allocated by the demangler and should be xfree'd. */ So IMHO, something like "la_sniff_from_mangled_name" would be even clearer. BTW, what do we do with the resulting demangled name? Is there some sort of guideline for options to pass to the demangler? Some sort of output that we're aiming for? Thanks, Pedro Alves