Re: [PATCH 2/2] gdb: change store_waitstatus to return a target_waitstatus by value

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-12-02 12:20, John Baldwin wrote:
> On 12/1/21 5:40 PM, Simon Marchi via Gdb-patches wrote:
>> store_waitstatus is basically a translation function between a status
>> integer and an equivalent target_waitstatus object.  It would make sense
>> for it to take the integer as a parameter and return the
>> target_waitstatus by value.  Do that, and rename to
>> host_status_to_waitstatus.  Users can then do:
>>
>>    ws = host_status_to_waitstatus (status)
>>
>> which does the right thing, given the move constructor of
>> target_waitstatus.
>>
>> Change-Id: I7a07d59d3dc19d3ed66929642f82f44f3e85d61b
>> ---
>>   gdb/gnu-nat.c        |  2 +-
>>   gdb/inf-child.c      | 17 +++++++++--------
>>   gdb/inf-child.h      |  5 ++---
>>   gdb/inf-ptrace.c     |  3 ++-
>>   gdb/linux-nat.c      |  6 +++---
>>   gdb/netbsd-nat.c     |  2 +-
>>   gdb/procfs.c         |  2 +-
>>   gdb/rs6000-aix-nat.c |  2 +-
>>   8 files changed, 20 insertions(+), 19 deletions(-)
>>
>> diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
>> index 13127cd82461..f24e1c523c6b 100644
>> --- a/gdb/gnu-nat.c
>> +++ b/gdb/gnu-nat.c
>> @@ -1821,7 +1821,7 @@ S_proc_wait_reply (mach_port_t reply, kern_return_t err,
>>       }
>>     else if (pid == inf->pid)
>>       {
>> -      store_waitstatus (&inf->wait.status, status);
>> +      inf->wait.status = host_address_to_string (status);
> 
> Typo?  (host_address_to_string vs host_address_to_waitstatus)
> 
> These two patches look good to me otherwise.
> 

Oops, the auto-complete played a trick on me.  Will fix locally, thanks
for taking a look.

Simon