From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IxD4EMYnF2lmYQEAWB0awg (envelope-from ) for ; Fri, 14 Nov 2025 07:59:50 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QvLrikrS; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=R6YHih9M; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QvLrikrS; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=R6YHih9M; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 32BBD1E057; Fri, 14 Nov 2025 07:59:50 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 212C51E057 for ; Fri, 14 Nov 2025 07:59:49 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9368D3858C24 for ; Fri, 14 Nov 2025 12:59:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9368D3858C24 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QvLrikrS; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=R6YHih9M; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QvLrikrS; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=R6YHih9M Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id E02AF3858D20 for ; Fri, 14 Nov 2025 12:59:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E02AF3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E02AF3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763125154; cv=none; b=rsuuSoSHg+HmV9QWpkCcWRjZZkvYRtyyjQ6bjuRzbwpYPF1EinQWaXfY6Xyscf73+FiNuedo2x4dhAhGA4oIeOvYgushTgF4pyNwaQgziucFyJainV4l2f6RhRERwdbJtjEPfJzmgIqLKiS7jZUm+v0NH+vKKafl+xcGqkfO2pE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763125154; c=relaxed/simple; bh=NwPvi8kUeuyml4qX/7GD7GA+wDDuaAo9ffK+AlgdyD4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=rvGWEaezwcdZmVERH5OHYg6ClTMh6B6WSdG5YPnHOLmKEx2OlDPAT5nP0jGTnpopHn5ZaQgE/JMI5KDPXwnj7YnLNUl4U7B0o+IXvMZP+q8n2y4DFg4MwosWYUwJ+tOS2oATZd6eRFmGymKIngC/mVM2d26lXSMcJ/eBtHCq37U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E02AF3858D20 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5BC441F745; Fri, 14 Nov 2025 12:59:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1763125152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W2CXqUcGHTH4c2swICVytstl87PP8ZprrPbVd1NazyM=; b=QvLrikrS8janU6P/H65yNsubYJ7gzWbpBqwJKYAJge3PPR2hFvaHH+ehRMLOOQhI3q8vV9 cv/vN6WNXTpZvKoN3PQiCmfwW0aJn2MZdetrtHAF2YM9BJs0YSAFAq5Ugw17R2IQpnpJDB rJOIgh8CqqkEzhoCPPJm6kKYYBtW9KQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1763125152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W2CXqUcGHTH4c2swICVytstl87PP8ZprrPbVd1NazyM=; b=R6YHih9MH9aWBDlfLkoGbAj8HHghs4ieijWyEoW22QPz/ooA9cigmUnbxXc+NAvVRrKdOo EHqvQLofKRtdviCQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1763125152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W2CXqUcGHTH4c2swICVytstl87PP8ZprrPbVd1NazyM=; b=QvLrikrS8janU6P/H65yNsubYJ7gzWbpBqwJKYAJge3PPR2hFvaHH+ehRMLOOQhI3q8vV9 cv/vN6WNXTpZvKoN3PQiCmfwW0aJn2MZdetrtHAF2YM9BJs0YSAFAq5Ugw17R2IQpnpJDB rJOIgh8CqqkEzhoCPPJm6kKYYBtW9KQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1763125152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W2CXqUcGHTH4c2swICVytstl87PP8ZprrPbVd1NazyM=; b=R6YHih9MH9aWBDlfLkoGbAj8HHghs4ieijWyEoW22QPz/ooA9cigmUnbxXc+NAvVRrKdOo EHqvQLofKRtdviCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 44BAB3EA61; Fri, 14 Nov 2025 12:59:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qq7yDqAnF2kaIgAAD6G6ig (envelope-from ); Fri, 14 Nov 2025 12:59:12 +0000 Message-ID: Date: Fri, 14 Nov 2025 13:59:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Mark Pascal as case-insensitive From: Tom de Vries To: Tom Tromey , gdb-patches@sourceware.org References: <20251113162811.616219-1-tromey@adacore.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:helo,sourceware.org:url]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email, suse.de:mid, imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 11/14/25 12:41 PM, Tom de Vries wrote: > On 11/13/25 5:28 PM, Tom Tromey wrote: >> The Pascal language is not case-sensitive, so implement the >> appropriate language method.  This fixes gdb.pascal failures with >> -gw3. >> >> I wasn't sure if -gw3 should be the default so I've left it as-is. >> > > Hi, > > I've tried out the patch with: > ... > $ make check TESTS=gdb.pascal/*.exp RUNTESTFLAGS=--target_board=unix/ > gdb:debug_flags=-gw2 > ... > and likewise with -gw3, and the results look good. > > LGTM. > FWIW, I just found DW_AT_identifier_case: ... <0>: Abbrev Number: 1 (DW_TAG_compile_unit) DW_AT_name : ../../../../src/gdb/testsuite/gdb.pascal/hello.pas <3f> DW_AT_producer : Free Pascal 3.2.2 2025/09/10 <5c> DW_AT_comp_dir : /data/vries/gdb/leap-16-0/build/gdb/testsuite/ <8b> DW_AT_language : 9 (ANSI Pascal) <8c> DW_AT_identifier_case: 3 (case_insensitive) <8d> DW_AT_stmt_list : 0 <91> DW_AT_low_pc : 0x401090 <99> DW_AT_high_pc : 0x401150 ... which enables a finer granularity. We currently don't support this, but I'm not sure if that's a relevant feature. Thanks, - Tom > Approved-By: Tom de Vries > > Thanks, > - Tom > > >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33617 >> --- >>   gdb/p-lang.h | 3 +++ >>   1 file changed, 3 insertions(+) >> >> diff --git a/gdb/p-lang.h b/gdb/p-lang.h >> index 87430bad13c..f3bb329bc02 100644 >> --- a/gdb/p-lang.h >> +++ b/gdb/p-lang.h >> @@ -154,6 +154,9 @@ class pascal_language : public language_defn >>     bool range_checking_on_by_default () const override >>     { return true; } >> +  enum case_sensitivity case_sensitivity () const override >> +  { return case_sensitive_off; } >> + >>   private: >>     /* Print the character C on STREAM as part of the contents of a >> literal >> >> base-commit: a85f1da7a82fef8c74737089b5845bfd2d97996c >