From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IOqdIMfl/WPLeAAAWB0awg (envelope-from ) for ; Tue, 28 Feb 2023 06:30:15 -0500 Received: by simark.ca (Postfix, from userid 112) id 82A541E222; Tue, 28 Feb 2023 06:30:15 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=VQ4QicDm; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 022351E128 for ; Tue, 28 Feb 2023 06:30:15 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 918C9384FB78 for ; Tue, 28 Feb 2023 11:30:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 918C9384FB78 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677583814; bh=VmS/nS1lM6+XP9HevHhBIeiLyprZIzi7JC/nG4cdFU0=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=VQ4QicDmyH9s/DhMN11snfCk7gnotcnM2FE4v73jzZiyHzgQTtsgPk9/ge8UKlqvQ AajFQ9v9mzq0WSd1U3tklzaT2zQf08KGjzI42yYM0gM4/+mXLEM0mccXiA14hMTCzq ViQyIQ438HM2rAYmSX7SODQZ7ETh/geaENRzk7ks= Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by sourceware.org (Postfix) with ESMTPS id DF14A3857C48 for ; Tue, 28 Feb 2023 11:29:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DF14A3857C48 X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="396679549" X-IronPort-AV: E=Sophos;i="5.98,221,1673942400"; d="scan'208";a="396679549" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2023 03:29:52 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="919748407" X-IronPort-AV: E=Sophos;i="5.98,221,1673942400"; d="scan'208";a="919748407" Received: from ultl2604.iul.intel.com (HELO localhost) ([172.28.48.47]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2023 03:29:51 -0800 To: gdb-patches@sourceware.org Subject: [PATCH 11/26] gdbserver: convert registers_from_string into regcache::registers_from_string Date: Tue, 28 Feb 2023 12:28:09 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tankut Baris Aktemur via Gdb-patches Reply-To: Tankut Baris Aktemur Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Convert the registers_from_string function into a method of the regcache struct. Also constify the buffer argument. --- gdbserver/regcache.cc | 4 +--- gdbserver/regcache.h | 7 +++---- gdbserver/server.cc | 2 +- 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc index 92dc6fc921c..156fda7068d 100644 --- a/gdbserver/regcache.cc +++ b/gdbserver/regcache.cc @@ -235,11 +235,9 @@ regcache::registers_to_string (char *buf) } void -registers_from_string (struct regcache *regcache, char *buf) +regcache::registers_from_string (const char *buf) { int len = strlen (buf); - unsigned char *registers = regcache->registers; - const struct target_desc *tdesc = regcache->tdesc; if (len != tdesc->registers_size * 2) { diff --git a/gdbserver/regcache.h b/gdbserver/regcache.h index bed3151dcad..6aa03a70352 100644 --- a/gdbserver/regcache.h +++ b/gdbserver/regcache.h @@ -88,6 +88,9 @@ struct regcache : public reg_buffer_common /* Convert all registers to a string in the currently specified remote format. */ void registers_to_string (char *buf); + + /* Convert a string to register values and fill our register cache. */ + void registers_from_string (const char *buf); }; regcache *get_thread_regcache (thread_info *thread, bool fetch = true); @@ -110,10 +113,6 @@ void regcache_invalidate (void); void regcache_release (void); -/* Convert a string to register values and fill our register cache. */ - -void registers_from_string (struct regcache *regcache, char *buf); - /* For regcache_read_pc see gdbsupport/common-regcache.h. */ void regcache_write_pc (struct regcache *regcache, CORE_ADDR pc); diff --git a/gdbserver/server.cc b/gdbserver/server.cc index f540cc86f7b..5e639d6ac57 100644 --- a/gdbserver/server.cc +++ b/gdbserver/server.cc @@ -4271,7 +4271,7 @@ process_serial_event (void) else { regcache = get_thread_regcache (current_thread); - registers_from_string (regcache, &cs.own_buf[1]); + regcache->registers_from_string (&cs.own_buf[1]); write_ok (cs.own_buf); } } -- 2.25.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928