From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: Make some test names unique
Date: Thu, 22 Jun 2017 12:12:00 -0000 [thread overview]
Message-ID: <fc05d9fb-a4dd-a84d-617f-541fa367a83a@redhat.com> (raw)
In-Reply-To: <c9b6ef063fbb5e33c157b1041418cd2fb7d8cf27.1497466455.git.andrew.burgess@embecosm.com>
On 06/14/2017 07:57 PM, Andrew Burgess wrote:
> @@ -95,7 +95,7 @@ mi_run_cmd
> mi_expect_stop "breakpoint-hit" "vla" "" ".*vla.f90" "$bp_lineno" \
> { "" "disp=\"del\"" } "run to breakpoint at line $bp_lineno"
> mi_gdb_test "520-data-evaluate-expression vla1" \
> - "520\\^done,value=\"\\(1, 1, 1, 1, 1\\)\"" "evaluate filled vla"
> + "520\\^done,value=\"\\(1, 1, 1, 1, 1\\)\"" "evaluate filled vla at line $bp_lineno"
>
As principle, please avoid putting line numbers in test names. This
causes test names to spuriously change if/when the source file changes.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-06-22 12:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 18:57 [PATCH 0/2] Couple of small fixes to gdb.mi/mi-vla-fortran.exp test Andrew Burgess
2017-06-14 18:58 ` [PATCH 1/2] gdb: Fix parameter passing to mi_create_breakpoint Andrew Burgess
2017-06-22 10:16 ` Yao Qi
2017-06-14 18:58 ` [PATCH 2/2] gdb: Make some test names unique Andrew Burgess
2017-06-22 10:37 ` Yao Qi
2017-06-22 11:08 ` Pedro Alves
[not found] ` <CAH=s-PNf8xHRCPzLsf3Ub8Wa=pz+h1O-ij=P2a1TeTRQT0VbuQ@mail.gmail.com>
2017-06-22 12:06 ` Pedro Alves
2017-06-22 12:12 ` Pedro Alves [this message]
2017-07-13 20:15 ` [PATCHv2 " Andrew Burgess
2017-07-13 22:40 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc05d9fb-a4dd-a84d-617f-541fa367a83a@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox