From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16418 invoked by alias); 8 Sep 2007 11:27:37 -0000 Received: (qmail 16410 invoked by uid 22791); 8 Sep 2007 11:27:37 -0000 X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 08 Sep 2007 11:27:26 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1ITyTA-00016o-A1 for gdb-patches@sources.redhat.com; Sat, 08 Sep 2007 13:27:20 +0200 Received: from 77.246.241.246 ([77.246.241.246]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 08 Sep 2007 13:27:20 +0200 Received: from ghost by 77.246.241.246 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 08 Sep 2007 13:27:20 +0200 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: [5/9] Associate parsed condition with location Date: Sat, 08 Sep 2007 11:27:00 -0000 Message-ID: References: <200709080042.24484.vladimir@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit User-Agent: KNode/0.10.4 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00109.txt.bz2 Eli Zaretskii wrote: >> From: Vladimir Prus >> Date: Sat, 8 Sep 2007 00:42:24 +0400 >> >> * breakpoint.c: Adjust. >> * tui/tui-winsource.c: Adjust. > > Nitpicking: these aren't, strictly speaking, valid ChangeLog entries, > because they don't name the functions where the changes were made. Yes; however this is highly mechanical change, there's nothing specific I can say about any function. >> --- gdb/breakpoint.h (/work/mb_mainline/4_bpstat_owner) (revision 4741) >> +++ gdb/breakpoint.h (/work/mb_mainline/5_per_loc_cond) (revision 4741) >> @@ -243,6 +243,13 @@ struct bp_location >> than reference counting. */ >> struct breakpoint *owner; >> >> + /* Conditional. Break only if this expression's value is nonzero. >> + Unlike string form of condition, which is associated with >> breakpoint, >> + this is associated with location, since if breakpoint has several >> + PC locations, the evaluation of expression can be different for >> + different PCs. */ >> + struct expression *cond; > > I think we should use ``location'' instead of ``PC'', since you make > the change for watchpoints as well, where the PC is irrelevant. Point taken, I'll see if I can reword this. - Volodya