From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by sourceware.org (Postfix) with ESMTPS id 128FF3842400 for ; Fri, 10 Jul 2020 14:31:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 128FF3842400 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wm1-f65.google.com with SMTP id f139so6128676wmf.5 for ; Fri, 10 Jul 2020 07:31:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=txSnEJBON5sU65RKr2bfe5zYg+snGfspR7alUe6kgB0=; b=FNjIju3wgYZeK338C8iKZuwEv8BE2ipifhYnqwfrpll5fho2RNsP6f/e1LVEeEGH/b BHCB/wY6hF594vor253fHUq5WJLXtBYhyvZzCWgkygPPuNvFZITveGO//Uz4iBcoIcF/ 5xJbRw0KONxhTESaanjXifbzAycdk4eQITVg+xwM/t8JgYx8WpoJA/ydrsHsI09B6PQR vd/GxqgpCuGpTWHYQz2ECzhxn0kIwJiWxAnZ2ZdyfGxDa20iX6I3ezc8GWqkk3jUwPSe weouT7o1qeZfCNNvHBBjU+tIQdSYMYAPrV1W7ewIzoCCCt64D/rkKMdDRlw2lc9FncDf Kj8Q== X-Gm-Message-State: AOAM532mMMllE6HreND9kx9qxZpmNwsqv1dhB5P6gC1g/HJA9qFcUyzb /GpsEUFLrhbPRFl8gaf8vcQVoloLkfPqKw== X-Google-Smtp-Source: ABdhPJzWPxeAzBGrqvzDWR1T175pGbYgxen7LcxgrQPDXipk00yyi4Awj4fbHsT8/QWEZlPrkNl/jA== X-Received: by 2002:a1c:2183:: with SMTP id h125mr5790585wmh.83.1594391475731; Fri, 10 Jul 2020 07:31:15 -0700 (PDT) Received: from ?IPv6:2001:8a0:f91a:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f91a:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id e5sm10337582wrs.33.2020.07.10.07.31.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2020 07:31:13 -0700 (PDT) Subject: Re: [PATCH v2] Skip VLA structure field tests when compiling with clang To: Gary Benson , Luis Machado References: <1594223215-21455-1-git-send-email-gbenson@redhat.com> <20200710120019.GA3062@blade.nx> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Fri, 10 Jul 2020 15:31:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200710120019.GA3062@blade.nx> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2020 14:31:18 -0000 On 7/10/20 1:00 PM, Gary Benson via Gdb-patches wrote: >>> +# Clang says it will never support variable length arrays in structures. >>> +if {[test_compiler_info clang*]} { >>> + unsupported "compiler does not variable length arrays in structure" >> >> ^^^ support? >> >> Otherwise this looks good to me. Can't approve a commit though. > > Good catch. Thanks for your review, I've fixed this in my tree. This is OK with that fixed. Thanks, Pedro Alves