From: Luis Machado <luis.machado@linaro.org>
To: Tom Tromey <tom@tromey.com>,
Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/6] Add column information of dwarf to the symbol information
Date: Tue, 19 May 2020 09:23:55 -0300 [thread overview]
Message-ID: <fbc2a356-26af-6a2b-8ce6-a9c3c555fd76@linaro.org> (raw)
In-Reply-To: <87blmli5ej.fsf@tromey.com>
On 5/18/20 1:17 PM, Tom Tromey wrote:
> Hannes> void
> Hannes> buildsym_compunit::record_line (struct subfile *subfile, int line,
> Hannes> - CORE_ADDR pc, bool is_stmt)
> Hannes> + CORE_ADDR pc, bool is_stmt, int column)
>
> I think putting the column parameter next to the line parameter would be
> more idiomatic.
>
> Tom
>
Should we avoid passing line/column separately and, instead, pass down a
struct containing both? They're part of the same high level information
(the position in the source file). That would be cleaner IMO.
next prev parent reply other threads:[~2020-05-19 12:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200516172632.4803-1-ssbssa.ref@yahoo.de>
2020-05-16 17:26 ` [RFC][PATCH 0/6] Step program considering the source column information Hannes Domani
2020-05-16 17:26 ` [PATCH 1/6] Add column information of dwarf to the symbol information Hannes Domani
2020-05-18 16:17 ` Tom Tromey
2020-05-19 12:23 ` Luis Machado [this message]
2020-05-16 17:26 ` [PATCH 2/6][PR gdb/25913] Implement nextc and stepc commands Hannes Domani
2020-05-16 17:26 ` [PATCH 3/6] Add column information to maint info line-table Hannes Domani
2020-05-16 17:26 ` [PATCH 4/6] Add LineTableEntry.column to python line table interface Hannes Domani
2020-05-27 13:50 ` Tom de Vries
2020-05-27 14:36 ` Tom Tromey
2020-05-16 17:26 ` [PATCH 5/6][PR gdb/25911] Show column of current execution point in frame info Hannes Domani
2020-05-18 16:20 ` Tom Tromey
2020-05-18 16:37 ` Hannes Domani
2020-05-19 14:51 ` Tom Tromey
2020-05-16 17:26 ` [PATCH 6/6] Show column of current execution point in TUI Hannes Domani
2020-05-16 18:45 ` [RFC][PATCH 0/6] Step program considering the source column information Pedro Alves
2020-05-17 0:08 ` Hannes Domani
2020-05-18 16:21 ` Tom Tromey
2020-05-18 16:28 ` Hannes Domani
2020-05-19 12:27 ` Luis Machado
2020-05-19 16:02 ` Hannes Domani
2020-05-27 15:33 ` Tom de Vries
2020-05-27 16:04 ` Hannes Domani
2020-06-02 9:08 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbc2a356-26af-6a2b-8ce6-a9c3c555fd76@linaro.org \
--to=luis.machado@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox