From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FgrlCp1R1Gd8WA8AWB0awg (envelope-from ) for ; Fri, 14 Mar 2025 11:56:13 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=K6n+0d5k; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1C2AD1E105; Fri, 14 Mar 2025 11:56:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 860B21E08E for ; Fri, 14 Mar 2025 11:56:09 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A797F3858C48 for ; Fri, 14 Mar 2025 15:56:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A797F3858C48 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=K6n+0d5k Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id B7D9D3857831 for ; Fri, 14 Mar 2025 15:51:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B7D9D3857831 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B7D9D3857831 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741967465; cv=none; b=UCc0gNjdWZRU2nV+vw3WEO3FkVelgw6vvKRrZg+lx2inzBXlWPae9+nvI82FeinrM1+qpW9O910P9ldelzJnFMLvQQQjMXjr5q5tQ2TuvQFpmaAtISzG4b826wTpCvh7xQyeG7MO4U4pHqQuCqGqgcsMenvt9QYgZ95T4ICheqI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741967465; c=relaxed/simple; bh=82vf6zKqPv64Axk4n/IzMqNKcvJ6CS7kTygs2+2fphQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=J2yG55gzq7V9bC8YKnQ1O0HCUWZeqFm0d4Lpl4gb8MXjjDfiam0N0yG7/dwjf2zYawZqlOpGBOyYUiKa2j1o/4jyrXvigccObeCUaNn7TFBbMjFZ10X9vLUx1HN2VXhW3jyq9Fkm/vKcwlNCQ0BMwNNR3FIQL1Xehvk/kbPswVM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B7D9D3857831 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741967465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6v+k8QbRS07YhIgVPtWiMlsJT6b2zSRkTfrks8Kn1ks=; b=K6n+0d5koprP53tuxiSYAFRS2cXZwnLKbLO+Gz0apz+sINqPOedcRDeOyweDNx34OvY5io DjEadrmP+DJJU0CRWMbS5ma48ceq9ErmFHZaV2yFzXNbjFk51GTqiA5UYSTyeZUD+KvJaX upFtwdwvPHrDEM8YwexZZxZX56Q/SlI= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-671-eCj5LmpoOYadxNjT25xUyw-1; Fri, 14 Mar 2025 11:51:04 -0400 X-MC-Unique: eCj5LmpoOYadxNjT25xUyw-1 X-Mimecast-MFC-AGG-ID: eCj5LmpoOYadxNjT25xUyw_1741967463 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-225107fbdc7so37487095ad.0 for ; Fri, 14 Mar 2025 08:51:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741967463; x=1742572263; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6v+k8QbRS07YhIgVPtWiMlsJT6b2zSRkTfrks8Kn1ks=; b=a5D6O3lv7Qjwi0h6wVnV9NzLIhFkBDaGwXuDejwu6wdD7ZjjMWzuY8LRlkyZudGty2 TcG726XLw3k9jdYyZZpjEo/5iavmBTLKJkh7fMVN/YvNpcZeauCxsowGPrm6Pb++zjwX +5tGxSZJ9EvN5kcvFYciX748i2q6S5clmJxmECy3vIMMwcFIUhp+hdf4bce+OEygQ6PA adImRpQxt8k1V8MaGR9nVVrkSd+HDYTIqhd5ucKJMkwY7bpdr8cIICP/JvhNcyWPpkm+ gitg2I7ITcMxa2oestOeqxKbFhaoBJGX6EbfoAQ+fB0PU13fpx50YevKhUsUV4mc6KkN bJBg== X-Forwarded-Encrypted: i=1; AJvYcCWiBVaH9+axzc9amSHoCFQn6/iDJfcq20IZe2HCvTZmwJ1K2vmOI9JPbmxRuKrIvbrUtyJKFjMDUqnP4w==@sourceware.org X-Gm-Message-State: AOJu0Yy3vf7mJJRcjbxzuOcFeR2cM9URYagesspr4VaQps+9F9GHbHI/ Hm01bVHvFW4YRQNkQw5UXzamFQBxSgU1O0r3qHEcGVsqHWQPM9V8CDr14DcV1e0Ls7C1xpLtcu5 lkseThTT5nhrdY9f8SLvgGUmjDunoL4kajo+SoSzrNPQAB4u8qncAdv8Lr/E= X-Gm-Gg: ASbGnctBBx5qCDrn12dbJV2+g5UM72rG3iSzYldZeG4A004cZNwMiSPVJw0uQu+mQ0H cX9GNlAI5Uc8uNyilO4ezBp6pVIJiyB5dfznxpkta1J4U0KPPEgIARAITj0TO/rEyo9vq52Tx6i mhq/DU3JduHza+K5keg1yEkE1FCUA2cOARQQKHIsVrYPZDp12JPRE2KrOxKEsdiY+n7y6nHOpyz KUkas51dRcuObjMmiizxRp6NIIjebAfFjo+dR0pOb9Iq4KPKHJtt0wLNUc0JH8ZAM34n4EqN/n+ 8qIxYe7n5n/Er7nUJKosS4dVTto= X-Received: by 2002:a05:6a00:464f:b0:736:4a5b:7f08 with SMTP id d2e1a72fcca58-737223fbd14mr3310228b3a.22.1741967462820; Fri, 14 Mar 2025 08:51:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IExAdbS5YO+sAval4pMh/btExbF/QNLln5bJuzYVzva78gctzIUSa+c2JC5fhsp1GmdY8QVTg== X-Received: by 2002:a05:6a00:464f:b0:736:4a5b:7f08 with SMTP id d2e1a72fcca58-737223fbd14mr3310199b3a.22.1741967462419; Fri, 14 Mar 2025 08:51:02 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:9a69::1001? ([2804:14d:8084:9a69::1001]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7371167da42sm3122284b3a.105.2025.03.14.08.51.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Mar 2025 08:51:02 -0700 (PDT) Message-ID: Date: Fri, 14 Mar 2025 12:50:58 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/tdep] Backport i386_canonicalize_syscall rewrite to gdb-16-branch To: Tom de Vries , Andrew Burgess , gdb-patches@sourceware.org References: <20250313095325.23876-1-tdevries@suse.de> <87frjhx8zz.fsf@redhat.com> <4e0a3406-0842-4d23-b8d7-53f995a273fa@suse.de> From: Guinevere Larsen In-Reply-To: <4e0a3406-0842-4d23-b8d7-53f995a273fa@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JCJpBaLuRQ-8dWbs8dCXT5TE4HCd3kFJh-_1kGf4Pns_1741967463 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/14/25 12:46 PM, Tom de Vries wrote: > On 3/13/25 16:09, Andrew Burgess wrote: >> Tom de Vries writes: >> >>> Commit fbfb29b304e ("[gdb/tdep] Rewrite i386_canonicalize_syscall") >>> fixes >>> PR32770, which reproduces on the gdb-16-branch, but the commit is >>> not ideal >>> for backporting because it completely rewrites >>> i386_canonicalize_syscall. >>> >>> Instead, this is a version of the patch that adds a single line >>> entry for each >>> syscall value for which i386_canonicalize_syscall gives a different >>> result >>> with and without the patch. >>> >>> Consequently, the two versions give identical results.  I've checked >>> this for >>> syscalls 0 to 466. >> >> Given you've shown that this is equivalent to the version in >> fbfb29b304e, and having taken a look at that commit, I'd be just as >> happy to see that commit merged into the gdb-16-branch.  The patch isn't >> small, but equally, it's pretty contained and straight forward, so I >> don't see huge risk there. >> >> But if you're happier with this approach in the gdb-16-branch, that's >> fine with me. >> > > Hi Andrew, > > thanks for the review. > > Gwen, do you have a preference? > > If not, given Andrew's assessment, I'll pick the patch from master > rather than this one. Not really, feel free to go with Andrew's suggestion :) -- Cheers, Guinevere Larsen She/Her/Hers > > Thanks, > - Tom > >> Approved-By: Andrew Burgess >> >> Thanks, >> Andrew >> >> >>> >>> Tested on x86_64-linux with target board unix/-m32, on top of >>> gdb-16-branch. >>> >>> PR tdep/32770 >>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32770 >> >