From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120711 invoked by alias); 24 Nov 2017 16:31:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120597 invoked by uid 89); 24 Nov 2017 16:31:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD,SPF_PASS autolearn=ham version=3.3.2 spammy=editor, UD:dtd, DTD, dtd X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Nov 2017 16:31:09 +0000 Received: from ESESSHC017.ericsson.se (Unknown_Domain [153.88.183.69]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 2D.39.07741.949481A5; Fri, 24 Nov 2017 17:31:06 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.69) with Microsoft SMTP Server (TLS) id 14.3.352.0; Fri, 24 Nov 2017 17:30:59 +0100 Received: from [142.133.61.121] (192.75.88.130) by AMSPR07MB312.eurprd07.prod.outlook.com (2a01:111:e400:802f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.2; Fri, 24 Nov 2017 16:30:57 +0000 Subject: Re: [PATCH 1/2] Fix issues with gdb-memory-map.dtd To: , Joel Brobecker References: <1510269503-12483-1-git-send-email-simon.marchi@ericsson.com> From: Simon Marchi Message-ID: Date: Fri, 24 Nov 2017 16:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1510269503-12483-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN4PR0501CA0128.namprd05.prod.outlook.com (2603:10b6:803:42::45) To AMSPR07MB312.eurprd07.prod.outlook.com (2a01:111:e400:802f::24) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603258);SRVR:AMSPR07MB312; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB312;3:nzCu5TnPI+GOSlb9TCD4VqgFqyfDAIvsr8pOG2E/IjiS2lcToODIJrX1m0JSMcgoMAmRzt+8ek6bVZG+PK9wN/v3OngHFrssIq2goVDjC1+OyT63XD9fdlgHE43HnmO5ta0BjwyXlp5cRDCj/obIRnsf8xdPZegIXZPb7n8qKSK2LdbTlbFcgcxtZzBYZkOH6C0s7e07xarlWddoSDzXJA0fsvzmoDJHptIh4mCsGcUKEXih5566Nwz813f5QeAp;25:Mgbp2n6pwgQyqIDz6bzouXW46Lj+TMLWYXNMX303qSOqb2PzzaYSgufypL0LeIteiW2unSSQVyxIbtlcV4m9RFioNpP71+gxahi5lcCZ+BIIGc+MHMfxYmZ8PZHE0p4hF8dJQvBmqCTVogD9oJUFn/H3tkYvuQZr64f14SZSKqgJRxDvDbwXxWsb99xI13cUMV/8LQFatBq9uSBkRr++ggqJAuj032E47Q6KdJP7NNFoENJScLJ14jCF1tmDoATUI3FSIKHWqV5/bZCSBGDE4GHwRo3T8Hn3VZXmzGJFr3TIkKjgCj213IzaqXd5ke79TnOtR5r86mFgSoFnMvwcSWbomEHlbcdXUHjW+KlZE7c=;31:pTpq9SRFYuEReS0u+eG+Dce0EIIzLcORC0k6aUGqcGH8QKxHA3BxwRu7AvR6mYe5yQH6YFJlISR01HTD/dRMWLHn83yxNmu0/CNEX28S/FD3vZNnghPWf7H5jKPqDI8CBmQQFleot7Zt458txWNStpDyjnfxDtlbH34gSGRRDOkDWqE1Mswcc/cdwkStwlaAl0d/P7n0z/klaiJoEOPWVY6j70HtJuriWCDlgkjJC8Y= X-MS-TrafficTypeDiagnostic: AMSPR07MB312: X-MS-Office365-Filtering-Correlation-Id: 593eb8a9-dd80-4591-9baa-08d53358be51 X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB312;20:88CJCXMpsu8dgoofno4bqvk6Zlj6Jed09qTaul0/qsD89UGB7iuawx/ALZce6R/938gwUHJGeu5Baa6dN1MvU+Nu+t4GaCgfr+n54zgT/RfiWge/vHC11Zn4g85bA4uteraA80P5tvGzPExwAVYOfa+rBvmj8RwuVmQZ3GQBpBtC3Xf187B4xdxk4j8flkNvy4cgkN+6UKepFtASpKAmKnHJ6wZYD0Hl9eIRBhN+bUNsbZZ5lZkpgOhiaqCMrzpRUZK6V4X4tw7TPVm+L124p/yShb0FqNFTxvPxb9iQIRV7sHMjC9XxxqvBvcelFMEvDvKNblLvjm52Ck0DHMVeqiBhXzCVkI+ViBf+8JLK2VF19Nb7NKAOgLfzUZSw7Pp97c3emxqDzK7rzvFXJYq/PrRMNGTYHvrxhgu7gGZpfTkwkInVN9X/y+Wz1rXMYTAMz3h0lcIhXLZ4+wngRlXCCEwh+v5VEG1A99AssP5PuepO1S0mgVwREFDjEowoer/i;4:2KWZ9FWLITZpgCw7khgmYmoEccyme6avOg+yWkbkHFbnFps+G0W5UipFiZ9WWUAKPdSu4kkgEvW8EJCbyos+jR+aYt+jr03Jr/Z875ity/T4SPioivXDg1hfnEdqLD78f+g94a/1EtQSzjOteiNpWg1c1R0iQHPe80QRKxEZQkNxrjF79j7LmnBbplusPnkBEeBHtOpoDTq6Ua+C5OsZ/onYab/70M4OPbVzzaMh9sJsZ1lIVCuh67a/U+51zCiSug9P3Elh7hOd5nChUj6wkC5Ryxj0q2/PVa7X+egvGWLi1hJzHmyVWbHOtazne1pf X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(131327999870524); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(10201501046)(3231022)(93006095)(93001095)(3002001)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(6072148)(201708071742011);SRVR:AMSPR07MB312;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:AMSPR07MB312; X-Forefront-PRVS: 05015EB482 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(346002)(39860400002)(376002)(366004)(54534003)(24454002)(199003)(377424004)(189002)(6486002)(58126008)(81156014)(966005)(83506002)(65806001)(8936002)(53936002)(64126003)(53376002)(6306002)(2486003)(86362001)(52116002)(229853002)(478600001)(105586002)(6666003)(6916009)(316002)(16576012)(31696002)(2906002)(6116002)(2950100002)(47776003)(50986999)(3846002)(76176999)(54356999)(49976008)(65826007)(5660300001)(7736002)(65956001)(230700001)(8676002)(31686004)(53546010)(36756003)(6246003)(33646002)(16526018)(68736007)(101416001)(81166006)(23676004)(305945005)(106356001)(189998001)(50466002)(97736004)(52146003)(230783001)(66066001)(25786009)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB312;H:[142.133.61.121];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzMTI7MjM6M1JONTVQMnhQVHNxRXRRNk85T1JsMjdiUGl2?= =?utf-8?B?UllIbit1WlUwMStZejhFUUFQWkJpMXd5VlBQUE45THVTeEE2aUJPUEpyNnhW?= =?utf-8?B?ZWQ2VkRrbWJJclZ2b2d4S2hUTkxRNmQrN0czaWUrWExDT1p5Q3dtdEh4Zm10?= =?utf-8?B?Vk8zcC9BUlpwa1loWmZxUU53YS9nMVZ5REFuaG1ISWowcCtoU2Q5R1ZTZ2wy?= =?utf-8?B?L2tLbmhzamNCYytRS1E1MlZOVGFaMGhoYlpMc1NldWUxSW1SMTIwUXkyVGFL?= =?utf-8?B?d1VkQlZPWi9wMmlFZVI5Vi9ZcjhkUTA0cHU3enVxZ1NiaWsvOEtDb3ZBNWZL?= =?utf-8?B?V0U1TGo1VmpFTGlWRkw4SXRUdkVJVENCVTExMDNIT0grTFhhcTRveEZBVVQ5?= =?utf-8?B?K2pIdzlBSUh5cGhYUGdSSUhGdVM3aXJLV1BuQ0h4LzVKWnFBZHF4Q01oMlR5?= =?utf-8?B?Y1VtYy9weUF2VnU4ekFJZURKcWFUdnFIdVRMNTJINk5YVFJMV05Oak9SemF0?= =?utf-8?B?NktTN1BRbzliekt2dVJVdFJiUy9ybFk3TTVYVGxXbXUrYk9ra2xDRG5NRDRn?= =?utf-8?B?UFEzNjQ2Y3JhOWRaYm1lZG94eGZIZm5qd1hsWHE3OThuaS82aURYWUtVa2ZC?= =?utf-8?B?TlVRbGt2Q1N3ZVFraUtqRzJMa25ubmtiS0p6bUFMSDNGZjFORFVJVWNDVnJj?= =?utf-8?B?eVpDeDlkckNzYVN3K24xd3p0aVVRVWdrWHBySlZ2T2d4MzErTXpza3N1MHUy?= =?utf-8?B?RGdyYlJUczVFYkh6U1hqWkdpbkZJQW9tN1VJbzVuSmE0RFF5LzE5bzUxV3B4?= =?utf-8?B?MTRzdHM1Y2ovbGJDa3FOUkxsRHhRaHpoWk9HOEo5N1hHM05xbmlwaVcyUXQz?= =?utf-8?B?MFRacmJESUFKMVZTMkZvaXRoSitzLy9sSUJldUpERDVkNDFRa1I0MnkxakFO?= =?utf-8?B?ekFOTkRsN2ltcjkvVTZvMjZFZXI3elREemcvZzdYcnNZc2JJMC9yVS9EL0d3?= =?utf-8?B?dnNEZ2s0ZTNTSnprR2IzNk9KdXYwcTI4UjZqeWVVS2tkQkpwSUc5V3NEV2Zi?= =?utf-8?B?VWQ1SHZHK1NUV0I5SWhWcmpySXJIZkVWTnhuSlVZRi9kOTAvVlVSMkNrdnhm?= =?utf-8?B?WUFLZGlraGZKZGh5d3FCSVFBZ29Mdk94M002NmpnVUxtWGtNTzc0ZHFMWlNu?= =?utf-8?B?TFhxYlhrWEVCOTcvLzFWVFgvWTZqKzk0MkR4M2l0T1ZNdER1ZUlTUk9ydFVt?= =?utf-8?B?c3hBZTJUSk0zaEV2N2I1dG9IMVBIUVBjdmdMYmdHMHVpNS9vVks5VFlvQXRH?= =?utf-8?B?YVR1aVZEU1l5blRFY1pJekVkNDhrZE1mVU4yaHh0N1p2Rk9hc3N6aTVCL2l5?= =?utf-8?B?SzMrVEtCMjBmcU5helZwbGZlZ1ltNFNnWWdEb3pvVzBvR1M3aTVkWUlvWk1o?= =?utf-8?B?cjIyWTZLc3hvZDFOT2V0UGlqbzdRQS9UUXdHZXZiNW1DNkJCWXdiSkp5SSs1?= =?utf-8?B?bk12a2FLNjBoZ3J5b3pxd2VGVWo3YlVvTjNWMVROVWozYUFydTlhS1NCR3NV?= =?utf-8?B?ZG1kWmR2a3FCUFk1VWszM2J1Wms3YzNpREZCYmpUSGlSTnZRUHFRcU1YQVFv?= =?utf-8?B?dFVoNXFDcngrVGlFZkJmbnptRHJ6UUJFZmZFaEdaWW1DNjBheU5yb0U1SzFy?= =?utf-8?B?NFJVUFk3ajJYMUpQYlVaZUFrb1hRWVpFTEVYb1NWQ2VSVGFuRWxsSXJRNi9n?= =?utf-8?B?SkluVXJBQlg2dUFadVZuZFFQZityV24yOUNUWTZzR2tEU0gzT01DeDFLOVRk?= =?utf-8?B?aGFCZ2JNU1NzdWdXQjlabDJBUXBWSTFGRncyVmJKZHlTYmhHc21ORjQ0WVNW?= =?utf-8?B?UDdFOVZ1cFU5TWcvTWJKNFVyWXlNWlRBRFZZa05FYlF3Qi81WStsSnhpUFBD?= =?utf-8?B?dmdRMTNTSFM4Rk5BN29qN3dERjN3Z3NrRXBIa2FTNE4raTM3ZnZTcU11SVJl?= =?utf-8?B?eldsdktaYlZuT2VZYmpvQW9lN0Joa2k0bEkzVlZuNGY2SFAzM1ZyL0t6TjNK?= =?utf-8?B?TmlCcnpUUVFVbVpaU1BaUVdoUVJ6YU5HWHFCQ3VXMkZITm84MFZUNXRhQVNO?= =?utf-8?B?UT09?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB312;6:4CiEtJ1nXSDNk+cPaQqX3LaabDnj7Z3vGbMfVvCdRu54sg0+HqpqVE9iHOW9d3OeKBl2CRQjz3KCpLwHjwOQpjizxAIhlzBr1wSLG7bZu2WyjE7roSLEg1eezGfI42Gs+GSzgolYo9tTApxr2EmaCLfx+DBmz+EJnf+ynEqD9Moeif2CmSeOZ+T9pi8weTOSWFGuSjVQlGW3roGyA0HrDVxCW7T/tvP9iln5I/d0eJlC4sRfkpVkOBzZAGe6QHFcwGuiCekw+Ka8KQQCGTKxnifVEr9oXk5m56gnr1VcsCgNumBe9s0G353MLpgmynTKMFOiIBLxIEfn2QUuisH1XjVWy3lWaaqMpbt7VChYZz8=;5:2dI/EKoZLF2UtvA8d6DLHalPNdUqmR4vL6/XL8hqHIykd/S+/Mhx2kyniyWJrIZekyNbnxflCNtKpTfcEtGC+Iy0gwzHFuNYqDZ8SvOweshVE4HcwM/NhoWfEqkw8cqIFh0swwp0r5/FnmqVBpoj38X5Et+KIDXHjr6HjDh+rvQ=;24:h2hbnyoSqbtPyjkP3ghJmIX97WKPwwC6rmtDZA1e3r6FZTuvFVgtb5rb8QRhs1b08JptX6VS9YHPKlXkqvgwpENagHUZBPUqinAxSIEK1gg=;7:gPBXeHE1c3kfx6MtVjcaRZn8iwpPbEeQf5hpZwz7wwEW8UMBG5ddWzb1F/5UhgAfbIQllP57LmxCEB2VWrs74rooAK5+fokalHT+zNSsNkxd7nH+A1Cogl5XHn/H5HC/nAtLURA6hp0Wdp0rfpm/3mdMjJFzCGIkO5Ye1P0BFSrN7MbTCLhD+dH0Z759QjrONjAJ0YbJatPnPAZ0TG73h/ob62lf/Amb5QOe9PCzFNWebCFjstM53qYQMAk94tEQ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2017 16:30:57.9076 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 593eb8a9-dd80-4591-9baa-08d53358be51 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB312 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00617.txt.bz2 On 2017-11-09 06:18 PM, Simon Marchi wrote: > While writing a unit test for parse_memory_map, I tried to validate my > test input against gdb-memory-map.dtd, and found a few problems with it. > This doesn't influence how gdb parses it (AFAIK it doesn't use the > linked dtd), but if you edit the xml file in an editor that supports > dtds, you'll get plenty of errors. > > - The element accepts exactly one OR > as a child. This is a problem because you can't have multiple > elements and you shouldn't be able to have elements > as direct children of . > - The element wants exactly one child. This is > wrong, since you could have zero or more (even though we only > support one kind of property currently). > - I have no idea wht the device attribute of is, GDB doesn't > read that. I searched back in time a bit but couldn't find a trace > of it. > > I took the opportunity to tighten what is accepted as a value of the > memory type and property name attributes. We currently accept any > string, but we could restrict them to the values GDB really accepts (and > which are documented). > > AFAIK, this "file" only exists in the documentation, in gdb.texinfo, so > this is what I modified. However, it's also available at > http://sourceware.org/gdb/gdb-memory-map.dtd. This one should be > updated too, but I don't know how that should be done. > > gdb/doc/ChangeLog: > > * gdb.texinfo (Memory Map Format): Update gdb-memory-map.dtd. > --- > gdb/doc/gdb.texinfo | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 29d4789..37d3e3d 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -40807,18 +40807,17 @@ The formal DTD for memory map format is given below: > > > > - > + > > - > + > > - + start CDATA #REQUIRED > - length CDATA #REQUIRED > - device CDATA #IMPLIED> > + length CDATA #REQUIRED> > > > - > + > @end smallexample > > @node Thread List Format > Hi Joel, You are probably the person that has the most chance to know how to update this file: http://sourceware.org/gdb/gdb-memory-map.dtd Any idea? Simon