From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EhwoNDbOMmDJSQAAWB0awg (envelope-from ) for ; Sun, 21 Feb 2021 16:18:46 -0500 Received: by simark.ca (Postfix, from userid 112) id C62201EF78; Sun, 21 Feb 2021 16:18:46 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 026C31E54D for ; Sun, 21 Feb 2021 16:18:46 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 414B6385783A; Sun, 21 Feb 2021 21:18:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 414B6385783A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1613942325; bh=zqYf/ALolbK34CxU05n+yAhTrzv0XvW+SOJnWqbmV1s=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=dxz/H/6pUCThX6Ey8qv+g0CK6NyHkxCv3RSWK3jxk4yhYr3Gy7ECDEh96SDClahBl CJCKP5DEuwUaWbLxidtNe2vUwbqNdx3/TVWubVFYgOyPAwC2tf1pwW0woZsUVOAqSQ ghMr9Q6yfsqEdNAPME4uZ6NIPeCS8hkxEl6mEA9A= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 3BDBC385783A for ; Sun, 21 Feb 2021 21:18:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3BDBC385783A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 11LLIXON025914 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 21 Feb 2021 16:18:38 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 11LLIXON025914 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9DC7C1E54D; Sun, 21 Feb 2021 16:18:33 -0500 (EST) Subject: Re: [PATCH 1/2] gdb: push target earlier in procfs_target::attach (PR 27435) To: Tom Tromey , Simon Marchi via Gdb-patches References: <20210221155630.3026942-1-simon.marchi@polymtl.ca> <87a6rxku96.fsf@tromey.com> Message-ID: Date: Sun, 21 Feb 2021 16:18:33 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <87a6rxku96.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 21 Feb 2021 21:18:33 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Libor Bukata Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-02-21 4:04 p.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> Tested by trying to attach on a process on gcc211 on the gcc compile > Simon> farm. > > Simon> gdb/ChangeLog: > > Simon> PR gdb/27435 > Simon> * inf-ptrace.c (struct target_unpusher): Move to target.h. > Simon> (target_unpush_up): Likewise. > Simon> * procfs.c (procfs_target::attach): Push target early. Use > Simon> target_unpush_up to unpush target in case of error. > Simon> * target.h (struct target_unpusher): Move here. > Simon> (target_unpush_up): Likewise. > > FWIW this looks reasonable to me. > > Tom Thanks, I'll wait for Libor's feedback before pushing. Simon