From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0FDFLWawLWW5ri8AWB0awg (envelope-from ) for ; Mon, 16 Oct 2023 17:51:34 -0400 Received: by simark.ca (Postfix, from userid 112) id B9CD21E0C1; Mon, 16 Oct 2023 17:51:34 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AE2DA1E098 for ; Mon, 16 Oct 2023 17:51:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2BE7E385AC3A for ; Mon, 16 Oct 2023 21:51:32 +0000 (GMT) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by sourceware.org (Postfix) with ESMTPS id ACA003858D37 for ; Mon, 16 Oct 2023 21:51:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ACA003858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ACA003858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697493082; cv=none; b=HFkYbZ9LEkSk0LnNfcAtIscKSbntjlH2/oC/qJ69fByGxHzz+NMNV1IYdeunn8jjGlMUdS0jZUmZvtNwHq0d+41HX33aqXUVKU0l+J0zPSyY2W233V7HpSrKCAVmh4uwZaOWT33ByqiuemS3CnGK85bTeQXQfNuC2mvrg/27RAQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697493082; c=relaxed/simple; bh=1Y9fd0DjhQ7BlHupzGDWsNNs3cpQnF/ZP5PFb+rQfpM=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=FLK/T2wkA1q5RulQTc5QWdjPC7AlAPT9wFF3yRXIbR2VnZ0mlFBwJO6JwGqXb1ocD8lcBbjUKP49Um75PWCw4BhLvhw0K4B077Um9fAEjeGAeY514/bXMhB0jKci0/n/V961944rbM2HZCdSqa4Vm9wrZEAXCRc0uKcXuq+zTo0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4066692ad35so51437005e9.1 for ; Mon, 16 Oct 2023 14:51:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697493080; x=1698097880; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jn2ePbGQ1o7+dSi01tp+/E7QMT/bfBWdkFhurPTxfSQ=; b=hLSWHd7cwwTFW2NOF4Zf+omt6IGMqT2t/rO9EPr8bgDYwjAQoWOAipZ/dH58jlM7ye ms7Q5CmDUM412ju/xPfzd5qmOjQPSjVQEgCFp4fheNe8mitQTX/Fnqr5RqSoMw0j8mX0 iSRFdxGx87WOkYs97A2hNUgqsF6oW8GcOsjGhTdi+s7ZnzWHTBWDYcrjezOhi4AfdBii ocG2uEsh3zSC2gaiyTpVMwMezpgnQyOjhTPwY4e52hPj2eBVz9P3KIHSSWkgQl3xSC3h ULs60EjELihuvv+ivmcZ9TsSC6TUAAeIaP3NWn/Y2g9za/dQZWpdy4Cspyo5Wq9L5Lh5 e2HA== X-Gm-Message-State: AOJu0YzO2Njt100MvGpUIi2NivfjzLjVqNYWYk4udOToXwtKtQpSOvpO pJN0XfcMAIgcQvv534Dh7mC7DzCE3yCPtw== X-Google-Smtp-Source: AGHT+IFBX5qU1JF6JcAuwkp8lhj2BtEoF5FrwOj1imXWjxHy7H82S6YKkcOPOpp+3JOgUU6K4RdqxQ== X-Received: by 2002:a05:600c:3587:b0:407:7e4b:67e7 with SMTP id p7-20020a05600c358700b004077e4b67e7mr275061wmq.39.1697493080288; Mon, 16 Oct 2023 14:51:20 -0700 (PDT) Received: from ?IPV6:2001:8a0:f939:d200:120b:b0fa:905:a893? ([2001:8a0:f939:d200:120b:b0fa:905:a893]) by smtp.gmail.com with ESMTPSA id l4-20020a05600c4f0400b00405959469afsm196403wmq.3.2023.10.16.14.51.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Oct 2023 14:51:19 -0700 (PDT) Message-ID: Date: Mon, 16 Oct 2023 22:51:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/11] gdb: Use std::string_view instead of gdb::string_view Content-Language: en-US To: Tom Tromey , Lancelot SIX Cc: gdb-patches@sourceware.org References: <20231013144418.3180617-1-lancelot.six@amd.com> <20231013144418.3180617-7-lancelot.six@amd.com> <87il78x49e.fsf@tromey.com> <87zg0iqs1p.fsf@tromey.com> From: Pedro Alves In-Reply-To: <87zg0iqs1p.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 2023-10-16 20:35, Tom Tromey wrote: >>>>>> "Lancelot" == Lancelot SIX writes: > > Lancelot> + std::string_view name; > Lancelot> + if (const char *name_str = keyname (ch); > Lancelot> + name_str != nullptr) > > We should probably discuss whether to allow this construct before > letting it in. > > Personally I'm ok with it. I think it may look a little weird if you're not used to it (like I am not), but OTOH it isn't really different from introducing a variable to scope with "for", like: for (const char *name_str = keyname (ch); name_str != nullptr; ....) .... so I suspect we'll all just get used to it and think nothing of it in a few years. So am I fine with it too.