From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id B0SWIGnP/2dC7jYAWB0awg (envelope-from ) for ; Wed, 16 Apr 2025 11:40:25 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=SoSnvbuI; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=fmKyU2SN; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=SoSnvbuI; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=fmKyU2SN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 766361E0C3; Wed, 16 Apr 2025 11:40:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8BAEC1E05C for ; Wed, 16 Apr 2025 11:40:24 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F2C563857C6D for ; Wed, 16 Apr 2025 15:40:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F2C563857C6D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=SoSnvbuI; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=fmKyU2SN; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=SoSnvbuI; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=fmKyU2SN Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 97CAB3858C41 for ; Wed, 16 Apr 2025 15:39:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 97CAB3858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 97CAB3858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744817989; cv=none; b=i5ieOvtBMK/tKxzp3nHy+yaooHaph07jQV8l93qJqNBV8h/WnW7+JA5QKovDndYdaKV9noNH4Kaotj8RMElwWYluM+ni99DGkZ94Rc/HUf4wz24NlAukYAB2mAcCXgO13fTrtpH9gjsAVlYrAbv+bEBuisq+DhCUnD4EXOCN1is= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744817989; c=relaxed/simple; bh=v87lO/9gxLk3N9EGiBYO3VTYUcHDiER/6x5+kHDdoos=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=YHXdeA1xqWQIIIxXjcBulvFy7K1bpPRAfYR8zXCuspt6kJKK0B6msrfb+XAGHW2nVnQ+1N7eNlE3HDBS4DVKl4miw2z6jP8IND3HRVm1SD9OiYj0lmbK+P6dPlKK+qnn0Bv8n79shY29JKW6/JAaIy0gLMoOC+UAgcnRN/DWR+s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 97CAB3858C41 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A3E8A2119D; Wed, 16 Apr 2025 15:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744817988; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rVnxbvrnEi0AfAFK+nDIy2BIJ05kYk7XozWn1Ju8pNM=; b=SoSnvbuIQCmgIXPaWV+XkACm7pT1aWH5W2yPmdknPZnfG3DHo35GCPHTsFFoRhcy1FgnGp vG21myM8vSh0yAdBQvn05Z7v0nfXY4V97SwZt6vPLwzs5ymosGCNBqQB2WDhRZM6iJASuR RDHS8+ymlciKXlBXmISuIWzxlK7HSpE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744817988; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rVnxbvrnEi0AfAFK+nDIy2BIJ05kYk7XozWn1Ju8pNM=; b=fmKyU2SNviVTRCnMNfY59KYU46lkrdTvOkQDordZ4GkBnyJgxz0YWeAz2MH6LNBXEDiIm9 O7GIagf4T+vvJqCw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=SoSnvbuI; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fmKyU2SN DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744817988; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rVnxbvrnEi0AfAFK+nDIy2BIJ05kYk7XozWn1Ju8pNM=; b=SoSnvbuIQCmgIXPaWV+XkACm7pT1aWH5W2yPmdknPZnfG3DHo35GCPHTsFFoRhcy1FgnGp vG21myM8vSh0yAdBQvn05Z7v0nfXY4V97SwZt6vPLwzs5ymosGCNBqQB2WDhRZM6iJASuR RDHS8+ymlciKXlBXmISuIWzxlK7HSpE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744817988; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rVnxbvrnEi0AfAFK+nDIy2BIJ05kYk7XozWn1Ju8pNM=; b=fmKyU2SNviVTRCnMNfY59KYU46lkrdTvOkQDordZ4GkBnyJgxz0YWeAz2MH6LNBXEDiIm9 O7GIagf4T+vvJqCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8E4BD13976; Wed, 16 Apr 2025 15:39:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +X5UIUTP/2eGYwAAD6G6ig (envelope-from ); Wed, 16 Apr 2025 15:39:48 +0000 Message-ID: Date: Wed, 16 Apr 2025 17:40:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/testsuite] Fix another timeout in gdb.base/bg-execution-repeat.exp To: Alexandra Petlanova Hajkova Cc: gdb-patches@sourceware.org References: <20250414115102.1991-1-tdevries@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A3E8A2119D X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/16/25 17:26, Alexandra Petlanova Hajkova wrote: > > > On Mon, Apr 14, 2025 at 1:51 PM Tom de Vries > wrote: > > With test-case gdb.base/bg-execution-repeat.exp, occasionally I run > into a > timeout: > ... > (gdb) c 1& > Will stop next time breakpoint 1 is reached.  Continuing. > (gdb) PASS: $exp: c 1&: c 1& > > Breakpoint 2, foo () at bg-execution-repeat.c:23 > 23        return 0; /* set break here */ > PASS: $exp: c 1&: breakpoint hit 1 > > Will stop next time breakpoint 2 is reached.  Continuing. > (gdb) PASS: $exp: c 1&: repeat bg command > print 1 > $1 = 1 > (gdb) PASS: $exp: c 1&: input still accepted > interrupt > (gdb) PASS: $exp: c 1&: interrupt > > Program received signal SIGINT, Interrupt. > foo () at bg-execution-repeat.c:24 > 24      } > PASS: $exp: c 1&: interrupt received > set var do_wait=0 > (gdb) PASS: $exp: c 1&: set var do_wait=0 > continue& > Continuing. > (gdb) PASS: $exp: c 1&: continue& > FAIL: $exp: c 1&: breakpoint hit 2 (timeout) > ... > > I can reproduce it reliably by adding a "sleep (1)" before the > "do_wait = 1" > in the .c file. > > The timeout happens as follows: > - with the inferior stopped at main, gdb continues (command c 1&) > - the inferior hits the breakpoint at foo > - gdb continues (using the repeat command functionality) > - the inferior is interrupted > - inferior variable do_wait gets set to 0.  The assumption here is > that the >   inferior has progressed enough that do_wait is set to 1 at that > point, but >   that happens not to be the case.  Consequently, this has no effect. > - gdb continues > - the inferior sets do_wait to 1 > - the inferior enters the wait function, and wait for do_wait to > become 0, >   which never happens. > > Fix this by moving the "do_wait = 1" to before the first call to foo. > > Tested on x86_64-linux. > --- > > Hi Tom, > > I also tested this on aarch64 and it works as expected, I think it's a > reasonable change. > Hi Alexandra, thanks for the review, pushed. - Tom > Reviewed-By: Alexandra Petlanova Hajkova >