From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sRjeBLaTFmHdGQAAWB0awg (envelope-from ) for ; Fri, 13 Aug 2021 11:45:58 -0400 Received: by simark.ca (Postfix, from userid 112) id 01BCC1EDFB; Fri, 13 Aug 2021 11:45:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 602F11E4A3 for ; Fri, 13 Aug 2021 11:45:57 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ED8973969C16 for ; Fri, 13 Aug 2021 15:45:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ED8973969C16 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1628869557; bh=+fP8bA8YiKKfi5+BvKgwhaKZfdNS5CsR5xnk/12LHXg=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=MYPBpLQJ2EQd2xOctwWh3gDJ6Ml7/csSRUrfVj+24QxffKBnzWFvMgrh9wVVnyTTU IY+btldHxyGmPOpMNbRmALbY0vp9F3PrzuYmzqiCKnci9Ho95L2D4Z7GGRyL4DXzMI SEJ9qUUmEaj6Zwmmmv/wTRCu13rHQdASkVKWxfxQ= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id DED813857C52 for ; Fri, 13 Aug 2021 15:45:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DED813857C52 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 17DFjGFo010979 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Aug 2021 11:45:21 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 17DFjGFo010979 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5EDCA1E4A3; Fri, 13 Aug 2021 11:45:16 -0400 (EDT) Subject: Re: [PATCH] Notify observer of breakpoint auto-disabling To: Patrick Monnerat , gdb-patches@sourceware.org References: <20210813153131.54709-1-patrick@monnerat.net> Message-ID: Date: Fri, 13 Aug 2021 11:45:16 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210813153131.54709-1-patrick@monnerat.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 13 Aug 2021 15:45:16 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-08-13 11:31 a.m., Patrick Monnerat via Gdb-patches wrote: > As observer in currently notified of breakpoint stop before handling its > auto-disabling after count is reached, the observer is never notified of > the disabling. > > This patch moves the observer notification after the auto-disabling > code. > > Fixes https://sourceware.org/bugzilla/show_bug.cgi?id=23336 > > * gdb/breakpoint.c (bpstat_stop_status): move observer notification > after auto-disabling code. > --- > gdb/breakpoint.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c > index 89af44ee4c6..feca224ccf4 100644 > --- a/gdb/breakpoint.c > +++ b/gdb/breakpoint.c > @@ -5491,7 +5491,6 @@ bpstat_stop_status (const address_space *aspace, > if (bs->stop) > { > ++(b->hit_count); > - gdb::observers::breakpoint_modified.notify (b); > > /* We will stop here. */ > if (b->disposition == disp_disable) > @@ -5501,6 +5500,7 @@ bpstat_stop_status (const address_space *aspace, > b->enable_state = bp_disabled; > removed_any = 1; > } > + gdb::observers::breakpoint_modified.notify (b); > if (b->silent) > bs->print = 0; > bs->commands = b->commands; > Is there some user-visible behavior change, that we could write a test for? Simon