From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WUeYHdLLy2mzwQAAWB0awg (envelope-from ) for ; Tue, 31 Mar 2026 09:27:46 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=n7sRpVaq; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=WdKFMHt3; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=A/GsN6PI; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=snQc0/KJ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7472D1E04F; Tue, 31 Mar 2026 09:27:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DB8621E04F for ; Tue, 31 Mar 2026 09:27:45 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 737C44BB58AE for ; Tue, 31 Mar 2026 13:27:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 737C44BB58AE Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=n7sRpVaq; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=WdKFMHt3; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=A/GsN6PI; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=snQc0/KJ Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 105654BA23E5 for ; Tue, 31 Mar 2026 13:27:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 105654BA23E5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 105654BA23E5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774963638; cv=none; b=CW6APMb5hPK2PyuJus3xDDwLDkgS/qHoFONMb4fqvfAx0pDAvJUeVOOEzJwW5+Yt0Eg3Cx08MghxOMNueiKLU1FvtzYBIUFYX5RFNwcMuE/vJwHCUaPponTAp6H+xW7Reqx03E91rlVk002nLubJxMbT29R1KVpuWEbE6qRAjYw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774963638; c=relaxed/simple; bh=A+fF37gQrXlPTQWSq7H02Emg18cbnEHP4H2OaFfAUdE=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=b5NhXdiGWUujy570MUqosy+6fp9rY0y3AwA49ZrywLXM2eQ/FF4WYT0t+Uw9lEhS1qLSjjH7j810KS554wdNIzuubZ7t1/HR2UcRGB4h8hXp+EcuknQsFXDIYF1VYmuIuc1AYG2xXnTdtXL1SiLT94UyqVvOxsjGFI/CNVlfJQo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 105654BA23E5 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E75ED5BEAC; Tue, 31 Mar 2026 13:27:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774963637; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HAbPJdv9jZKzXDOKG6YKFMCDjMYHhx8oDwH4tsHJpEM=; b=n7sRpVaqqVm+dWyqO0rcDTc4LeK5ytbLo2GfqX4KH1Af3ql4gRWBvOREnjdJGywt1yklOe H89W3w5PZrX/9O5IpZzZzlYyDgAi7PcphFGjMNUgQq55NDaXjTyH++GUXyQuxJzJAbzEZB GsZ66+WCYfqTwyxP1Ao5F3nHttVpHQ4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774963637; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HAbPJdv9jZKzXDOKG6YKFMCDjMYHhx8oDwH4tsHJpEM=; b=WdKFMHt3VQhrjJZUC07eZqV53h+jFl126iMIEFQf4iAVJ9r7kC/4FeW4O61vqKVXY8esYZ GQZ+sokAnhPmDPCQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="A/GsN6PI"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="snQc0/KJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774963636; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HAbPJdv9jZKzXDOKG6YKFMCDjMYHhx8oDwH4tsHJpEM=; b=A/GsN6PIHOgIYAIfk7JpuKktTc40m7XHhzkRZIziNJOUOQ5IPRj5hwIa26eitKtAKxkGmd l2cegY0ZPdS8T7rQv03L99vAEC5oAwKQJWiZ7/XASBGfMSgozhsAJKz4qLme9Zf1lE7AdJ LZOL35k7glpNsIAAogERepwTTq1aCMc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774963636; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HAbPJdv9jZKzXDOKG6YKFMCDjMYHhx8oDwH4tsHJpEM=; b=snQc0/KJsZcmsiICUEZOUXSls9GJmo/ZXx7XyIn/wgUzon8VTDeXMj/tZK8z/bZy3o4A+h VoAVrLceWL7V2YCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D22E74A0A2; Tue, 31 Mar 2026 13:27:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gzoAMrTLy2m9VwAAD6G6ig (envelope-from ); Tue, 31 Mar 2026 13:27:16 +0000 Message-ID: Date: Tue, 31 Mar 2026 15:27:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb] Fix missing print frame when stepping out of function From: Tom de Vries To: Andrew Burgess , gdb-patches@sourceware.org References: <20260312120211.3806600-1-tdevries@suse.de> <871phh6wir.fsf@redhat.com> <9e466544-aca0-4a0e-89fe-0221dfb5f7ed@suse.de> Content-Language: en-US In-Reply-To: <9e466544-aca0-4a0e-89fe-0221dfb5f7ed@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DBL_BLOCKED_OPENRESOLVER(0.00)[sourceware.org:url,suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: E75ED5BEAC X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/19/26 7:03 PM, Tom de Vries wrote: >> I think that it is worth at least investigating altering >> step_start_function to track the actual function, including inline >> functions, this seems like it would be a better fix.  But if not then at >> least we'll understand why it's not the right solution. > > Hi, > > just a small update on this. > > I've given this a try ( https://github.com/vries/gdb/tree/gdb/fix- > missing-print-frame-when-stepping-out-of-function-2 ) and ran into > trouble with just one test-case, gdb.opt/inline-cmds.exp ). > > Basically, with current gdb we have: > ... > 63      x = 7; > (gdb) s > 64      y = 8; /* set mi break here */ > (gdb) s > 66      result = func1 (); > (gdb) > ... > and with the patch series posted above: > ... > 63      x = 7; > (gdb) s > 64      y = 8; /* set mi break here */ > (gdb) s > main () at /data/vries/gdb/leap-16-0/build/../../src/gdb/testsuite/ > gdb.opt/inline-cmds.c:66 > 66      result = func1 (); > (gdb) > ... > > There is some code somewhere that allows entry into an inline function > to happen in two steps, even if the pc stays the same inbetween, and > that code seems to interact with the solution in the patch series. > > I'll take a further look tomorrow. Hi Andrew, this estimate turned out to be somewhat optimistic, but I've taken a look today, and submitted a v2 with the RFC tag ( https://sourceware.org/pipermail/gdb-patches/2026-March/226269.html ), containing the analysis of the regression mentioned above. Thanks, - Tom