From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 1G3hMF1isGlGDCIAWB0awg (envelope-from ) for ; Tue, 10 Mar 2026 14:26:37 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=AayofTp2; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B0F841E089; Tue, 10 Mar 2026 14:26:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 045961E089 for ; Tue, 10 Mar 2026 14:26:37 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 807E74BAD15C for ; Tue, 10 Mar 2026 18:26:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 807E74BAD15C Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=AayofTp2 Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 3E54C4BAD15C for ; Tue, 10 Mar 2026 18:26:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E54C4BAD15C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3E54C4BAD15C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773167169; cv=none; b=lwqFyo+V/3hXeS3bO9099YBa/Uy51wA/+UBwGf2oxyuvFTh8ZQWyk607ptJYPPuDb/HyRMrpUywKsu8buwtaJ6mjanOyjLmznB8FkpcebOzNlJPcEX9LB7KyqATynY+TDvdSOSdFnkiGlpBDeXfY6d/WhqgU8veIcXeOTQDxyIk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773167169; c=relaxed/simple; bh=JeCgWCMMzQZ84d5yVYMSTYLvn01tNE13kJ00eGX1weg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=O2k01c8IKNP2QO8pHskZptiR906hwIBi9np0BG+7BA7t2ou/xol3KkHVQGlYxNKEaf856D9ljINggqKJ22DFMQcwKPJa4oP22ylSNGazoCEBZg5HbAIBWwsEIg1fNJk/USv9FCaAUmSKtbEnQTSR0GpFM4i0aaddb3IvxLdQPek= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3E54C4BAD15C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 62AIQ2GM159338 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Mar 2026 14:26:07 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 62AIQ2GM159338 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1773167168; bh=5+ESOcA3oIKToJ+2xjsrlAm3Hl8mtEjyokJLNm+tRgE=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=AayofTp2sgoqOEh3kMDLy7MPyRaLY0/RDMODKvBPhp7OmXQGCzEHMRj7vDMVriazQ NW5vMfCi185y0QMXQ3eY+i2tpy483XkyAnokYUMT/tI4Tj3NQaoYKIJEze2W0NvAvt tzqld3HE4A1Q9YFdLzRW+75zRhbSPVEq9MSglGVCV+4roCvGYHlciZ/ysLHxMhRyZo wLM4BvUBcw4YIV83svK+YkbOi85MUNxgTjRJX5XY4Bgb3OGY/nw5KYZhOMl0nhxj5f LrEF9re2xZHrAd5QE6SKFBfXk8JFYtZFp033L1+eONjjy5N/p90dCKuycM/foAKjXu M7WKao8lvshmA== Received: by simark.ca (Postfix) id B5EED1E089; Tue, 10 Mar 2026 14:26:01 -0400 (EDT) Message-ID: Date: Tue, 10 Mar 2026 14:26:00 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/dwarf: implement section_and_offset comparison using operator== To: Tom Tromey Cc: gdb-patches@sourceware.org, Simon Marchi References: <20260310174458.747011-1-simon.marchi@polymtl.ca> <87jyvjtuoy.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87jyvjtuoy.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 10 Mar 2026 18:26:03 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-03-10 14:18, Tom Tromey wrote: >>>>>> "Simon" == simon marchi writes: > > Simon> From: Simon Marchi > Simon> This was suggested during review. > > Thanks. > > I thought there was some other code instantiating & using > section_and_offset_eq? > > Anyway this is good. > Approved-By: Tom Tromey > > Tom I think it was only used in an htab_t comparator that disappeared in the latest patch of the series, which moved to gdb::unordered_map. Pushed, thanks. Simon