From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yMSUBmiaU2FUEwAAWB0awg (envelope-from ) for ; Tue, 28 Sep 2021 18:42:48 -0400 Received: by simark.ca (Postfix, from userid 112) id 186FB1EE25; Tue, 28 Sep 2021 18:42:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 760371EDF0 for ; Tue, 28 Sep 2021 18:42:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 17186385802A for ; Tue, 28 Sep 2021 22:42:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 17186385802A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1632868967; bh=Z7Q80Aw7JS+1XoUgTW0N5yZFrm0YpgR9w/HL66eQb9c=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=TwyX8R3GON71DaxHmwxRGeuS87AIf2JNrA8bpKDk9MzrN8GRKEuRKNi24i3v72EA0 I5TNzLMd0A0egTpDnNRRJXGe2DHWmtzYhhPW8OnBucvkQZeWfFUKtwdNJy5151pTDe 9WeR+Pdxd6sbDO3AQoRjMHRX0mfAjfWgOOW8xcEM= Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 62A813858D35 for ; Tue, 28 Sep 2021 22:42:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 62A813858D35 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 92D261FDA8; Tue, 28 Sep 2021 22:42:25 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7D29913EB3; Tue, 28 Sep 2021 22:42:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4aN7HVGaU2EwJwAAMHmgww (envelope-from ); Tue, 28 Sep 2021 22:42:25 +0000 Subject: Re: [PATCH][gdb/testsuite] Fix gdb.multi/multi-term-settings.exp To: Pedro Alves , gdb-patches@sourceware.org References: <20210928175722.GA15861@delia> <81b6b3e3-12c4-e074-1b5d-70c7be375a11@palves.net> Message-ID: Date: Wed, 29 Sep 2021 00:42:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <81b6b3e3-12c4-e074-1b5d-70c7be375a11@palves.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 9/28/21 8:14 PM, Pedro Alves wrote: > On 2021-09-28 6:57 p.m., Tom de Vries wrote: >> Hi, >> >> When running test-case gdb.multi/multi-term-settings.exp in conjunction with: >> ... >> $ stress -c $(($(cat /proc/cpuinfo | grep -c ^processor) + 1)) >> ... >> I run into: >> ... >> (gdb) PASS: gdb.multi/multi-term-settings.exp: \ >> inf1_how=attach: inf2_how=attach: info inferiors >> pid=14783, count=59^M >> pid=14783, count=60^M >> ... >> pid=14783, count=118^M >> pid=14783, count=119^M >> pid=14778, count=90^M >> pid=14778, count=91^M >> pid=14778, count=92^M >> pid=14778, count=93^M >> pid=14778, count=94^M >> pid=14778, count=95^M >> PASS: gdb.multi/multi-term-settings.exp: inf1_how=attach: inf2_how=attach: continue >> Quit^M >> (gdb) FAIL: gdb.multi/multi-term-settings.exp: \ >> inf1_how=attach: inf2_how=attach: stop with control-c (SIGINT) >> ... >> >> It occurred to me that the "Continuing." we see otherwise is not shown and >> that it's possible that the control-C that is send is caught by gdb when >> printing this. >> >> Fix this by waiting for the "Continuing." message before sending control-C. >> >> Tested on x86_64-linux. >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=24929 >> >> Any comments? >> > > Hmm, think rang a bell. I had posted a patch for this a few months back: > > https://sourceware.org/pipermail/gdb-patches/2021-June/179503.html > > The idea is the same, but my version is more complete, IMHO. > > Sorry I didn't think of splitting that one out of the series at the time, this > could have been fixed all this time. :-/ > Np. I applied the patch locally and it works for me. Anything preventing this from going in now? Thanks, - Tom