From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59834 invoked by alias); 24 Aug 2017 19:09:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59424 invoked by uid 89); 24 Aug 2017 19:09:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: aserp1040.oracle.com Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Aug 2017 19:09:44 +0000 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v7OJ9eck004105 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Aug 2017 19:09:41 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v7OJ9e8o009151 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Aug 2017 19:09:40 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v7OJ9eFM007764; Thu, 24 Aug 2017 19:09:40 GMT Received: from [10.159.146.13] (/10.159.146.13) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 24 Aug 2017 12:09:39 -0700 Subject: Re: [PATCH] break gdb build on 32-bit host with ADI support To: Pedro Alves , gdb-patches@sourceware.org References: <1503595405-89600-1-git-send-email-weimin.pan@oracle.com> <479506e1-9478-1a38-d15c-3df13a817fff@redhat.com> From: Wei-min Pan Message-ID: Date: Thu, 24 Aug 2017 19:09:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <479506e1-9478-1a38-d15c-3df13a817fff@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2017-08/txt/msg00476.txt.bz2 On 8/24/2017 11:07 AM, Pedro Alves wrote: > On 08/24/2017 06:23 PM, Weimin Pan wrote: > >> diff --git a/gdb/sparc64-tdep.c b/gdb/sparc64-tdep.c >> index 6f4fca7..0da2ae5 100644 >> --- a/gdb/sparc64-tdep.c >> +++ b/gdb/sparc64-tdep.c >> @@ -90,12 +90,12 @@ static struct cmd_list_element *sparc64adilist = NULL; >> typedef struct >> { >> /* The ADI block size. */ >> - unsigned long blksize; >> + unsigned long long blksize; >> >> /* Number of bits used for an ADI version tag which can be >> * used together with the shift value for an ADI version tag >> * to encode or extract the ADI version value in a pointer. */ >> - unsigned long nbits; >> + unsigned long long nbits; > Do you really need to count 64-bit bits? :-P :-) Since the value of either nbits or blksize is between 0 and 64, no, I really don't. But without a 32-bit host, I'm simply play safe here so that the compiler won't bark. > (Formatting of comment is incorrect for GNU code, BTW. No '*' > on each line.) Corrected. >> >> /* The maximum ADI version tag value supported. */ >> int max_version; >> @@ -223,9 +223,10 @@ adi_available (void) >> >> proc->stat.checked_avail = true; >> if (target_auxv_search (¤t_target, AT_ADI_BLKSZ, >> - &proc->stat.blksize) <= 0) >> + (CORE_ADDR *)&proc->stat.blksize) <= 0) > Please don't introduce potential aliasing problems. Also, missing > space before &. > > Either make blksize really be a CORE_ADDR or do > > CORE_ADDR value; > if (target_auxv_search (¤t_target, AT_ADI_BLKSZ, &value) <= 0) > return false; > proc->stat.blksize = value; Since neither blksize nor nbits is a CORE_ADDR, I'm taking your second suggestion. >> - target_auxv_search (¤t_target, AT_ADI_NBITS, &proc->stat.nbits); >> + target_auxv_search (¤t_target, AT_ADI_NBITS, >> + (CORE_ADDR *)&proc->stat.nbits); >> proc->stat.max_version = (1 << proc->stat.nbits) - 2; >> proc->stat.is_avail = true; >> > Ditto. > >> @@ -346,7 +347,8 @@ adi_read_versions (CORE_ADDR vaddr, size_t size, unsigned char *tags) >> if (!adi_is_addr_mapped (vaddr, size)) >> { >> adi_stat_t ast = get_adi_info (ptid_get_pid (inferior_ptid)); >> - error(_("Address at 0x%lx is not in ADI maps"), vaddr*ast.blksize); >> + error(_("Address at 0x%llx is not in ADI maps"), >> + (long long)(vaddr*ast.blksize)); >> } > Use paddress instead? Also spaces around '*' and after the cast. Where is paddress defined? I tried casting to "uint64" which yields to "unsigned long" on a 64-bit host and didn't bode well with %llx. >> >> int target_errno; >> @@ -366,7 +368,8 @@ adi_write_versions (CORE_ADDR vaddr, size_t size, unsigned char *tags) >> if (!adi_is_addr_mapped (vaddr, size)) >> { >> adi_stat_t ast = get_adi_info (ptid_get_pid (inferior_ptid)); >> - error(_("Address at 0x%lx is not in ADI maps"), vaddr*ast.blksize); >> + error(_("Address at 0x%llx is not in ADI maps"), >> + (long long)(vaddr*ast.blksize)); > Ditto. > >> } >> >> int target_errno; >> @@ -387,7 +390,7 @@ adi_print_versions (CORE_ADDR vaddr, size_t cnt, unsigned char *tags) >> while (cnt > 0) >> { >> QUIT; >> - printf_filtered ("0x%016lx:\t", vaddr * adi_stat.blksize); >> + printf_filtered ("0x%016llx:\t", (long long)(vaddr*adi_stat.blksize)); > paddress / hex_string / phex_nz ? ?? >> for (int i = maxelts; i > 0 && cnt > 0; i--, cnt--) >> { >> if (tags[v_idx] == 0xff) /* no version tag */ >> @@ -418,7 +421,7 @@ do_examine (CORE_ADDR start, int bcnt) >> if (read_cnt == -1) >> error (_("No ADI information")); >> else if (read_cnt < cnt) >> - error(_("No ADI information at 0x%lx"), vaddr); >> + error(_("No ADI information at 0x%llx"), (long long)vaddr); > padress. > >> >> adi_print_versions (vstart, cnt, buf); >> >> @@ -438,7 +441,7 @@ do_assign (CORE_ADDR start, size_t bcnt, int version) >> if (set_cnt == -1) >> error (_("No ADI information")); >> else if (set_cnt < cnt) >> - error(_("No ADI information at 0x%lx"), vaddr); >> + error(_("No ADI information at 0x%llx"), (long long)vaddr); > paddress. > > BTW, this cast to long here: > > static CORE_ADDR > adi_normalize_address (CORE_ADDR addr) > { > adi_stat_t ast = get_adi_info (ptid_get_pid (inferior_ptid)); > > if (ast.nbits) > return ((CORE_ADDR)(((long)addr << ast.nbits) >> ast.nbits)); > return addr; > } > > looks suspiciously bogus to me. Consider a 32-bit host > remote/cross debugging a SPARC64 target machine. Also consider > a Win64-hosted GDB. Good point. Changing it to:       return ((long long)(((long long)addr << ast.nbits) >> ast.nbits)); Thanks. > > Thanks, > Pedro Alves >