From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46392 invoked by alias); 30 Mar 2018 05:28:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46383 invoked by uid 89); 30 Mar 2018 05:28:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Mar 2018 05:28:01 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w2U5RsbC012656 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 30 Mar 2018 01:27:59 -0400 Received: by simark.ca (Postfix, from userid 112) id 8D70B1E77A; Fri, 30 Mar 2018 01:27:54 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 1A1B91E030; Fri, 30 Mar 2018 01:27:54 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 30 Mar 2018 05:28:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/2] Change target_read_string to use unique_xmalloc_ptr In-Reply-To: <20180328042424.15276-2-tom@tromey.com> References: <20180328042424.15276-1-tom@tromey.com> <20180328042424.15276-2-tom@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.4 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 30 Mar 2018 05:27:54 +0000 X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00604.txt.bz2 On 2018-03-28 00:24, Tom Tromey wrote: > This changes the out parameter of target_read_string to be a > unique_xmalloc_ptr. This avoids a cleanup and sets the stage for more > cleanup removals. > > This patch also removes a seemingly needless alloca from > print_subexp_standard. That looks fine to me. Simon