From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 68DDA385DC00 for ; Sun, 31 May 2020 14:47:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 68DDA385DC00 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-7-uMYPRs6UOdyfwRm3n4kEKw-1; Sun, 31 May 2020 10:47:35 -0400 X-MC-Unique: uMYPRs6UOdyfwRm3n4kEKw-1 Received: by mail-wr1-f70.google.com with SMTP id e1so3546727wrm.3 for ; Sun, 31 May 2020 07:47:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=X0U3pT5xA49ptmyWzy10dy0C0OBsmFndx42KjGgAsGo=; b=Uy3O3I7jSobNlGMFGl20VNW0IIfoWzSL6U0ITWptSth9dC892iA/FGDt51KtkEq5M6 tEuCVi22gmMCu1os76UyJ6ra/Rq/CRVVXm7N9Zbgmx7T1lYo3I1hhI6hLK30pfoOt3u2 Py2lsQid4KXs3AnvjpmEV27DYOFjS8gzjWXD7WeUlkLiAWd6bD7qvhrGTBVogrELnCfj VCnoa1px8WW688efYxZbd8OFlH2rb6mMXix+/jgqJ961gSbOsQls5ntA1YgjLPd1aFr9 ZyocKLLezKHfyPTx80FvFmRHghKs++JAcO02IfZ5FkKG99//pkgIqIMSSFcwD0rpDhwp ePyw== X-Gm-Message-State: AOAM530WfEZODpMlfEMxoKXx0ZHZ02efd1teC2rcKbml08gGhErRLh5p DhauVLegfTjYIhZe2gVXlQXEQdPDXOrOrS2+S5JhqA/jwfIKtYa5Hneq/mcQNbXItulYb8EMLO9 k5XBoHEeYtp/qAh5n9fhRow== X-Received: by 2002:a05:600c:1084:: with SMTP id e4mr18268984wmd.144.1590936454023; Sun, 31 May 2020 07:47:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytUT1uhY97H14nf0umvQJkwTurHTTAjPvMLLZshfOwmR+Pk2Ek9YdZutQEWv6TJ5ozuBPAgw== X-Received: by 2002:a05:600c:1084:: with SMTP id e4mr18268971wmd.144.1590936453819; Sun, 31 May 2020 07:47:33 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id k21sm13187177wrd.24.2020.05.31.07.47.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 May 2020 07:47:32 -0700 (PDT) Subject: Re: [PATCH v2][PR gdb/24052] Implement 'set print zero-values on|off' To: Hannes Domani , Gdb-patches References: <20200530161253.61299-1-ssbssa.ref@yahoo.de> <20200530161253.61299-1-ssbssa@yahoo.de> <1980167901.498897.1590883592361@mail.yahoo.com> From: Pedro Alves Message-ID: Date: Sun, 31 May 2020 15:47:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 May 2020 14:47:38 -0000 On 5/31/20 2:38 PM, Pedro Alves via Gdb-patches wrote: > Yes, something like that. I guess also for unions. You should add a > test for unions too, btw. I think it would be good to test bitfields too. Not sure the value_is_zero check works correctly with bitfields as is, since that is checking byte per byte. Thanks, Pedro Alves