From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37410 invoked by alias); 6 Mar 2019 22:01:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37250 invoked by uid 89); 6 Mar 2019 22:00:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=BAYES_00,DNS_FROM_AHBL_RHSBL,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 spammy=HX-Spam-Relays-External:2001, tonight X-HELO: mail-wr1-f68.google.com Received: from mail-wr1-f68.google.com (HELO mail-wr1-f68.google.com) (209.85.221.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Mar 2019 22:00:46 +0000 Received: by mail-wr1-f68.google.com with SMTP id n2so15148020wrw.8 for ; Wed, 06 Mar 2019 14:00:45 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id c126sm4219243wma.0.2019.03.06.14.00.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Mar 2019 14:00:42 -0800 (PST) Subject: Re: [PATCH v2 21/22] Use SCOPE_EXIT in write_gcore_file To: Tom Tromey , gdb-patches@sourceware.org References: <20190227201849.32210-1-tom@tromey.com> <20190227201849.32210-22-tom@tromey.com> From: Pedro Alves Message-ID: Date: Wed, 06 Mar 2019 22:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190227201849.32210-22-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00131.txt.bz2 On 02/27/2019 08:18 PM, Tom Tromey wrote: > This replaces a try/catch in write_gcore_file with a use of SCOPE_EXIT > instead. I find that this is simpler to understand. > > gdb/ChangeLog > 2019-02-27 Tom Tromey > > * gcore.c (write_gcore_file): Use SCOPE_EXIT. You could rebase this on current master and push it in, to get it out of the way. You could also merge patches #1-#13, the cleanup-elimination patches until the TRY/CATCH parts. I'll need a bit more time to comment on those TRY/CATCH parts, so I've skipped them tonight. Thanks, Pedro Alves