Re: [PATCH v2] H8/300: sim: Fix simulator hang caused by qsort on Windows/MinGW

[Jeff Law <jeffrey.law@oss.qualcomm.com>]

On 9/1/26 1:05 AM, Jan Dubiec wrote:
> On Windows, qsort() uses an unstable sorting algorithm, which results
> in a "shuffled" opcode table rather than a properly sorted one, causing
> the entire simulator to hang.
>
> The simulator happens to work on Linux, but this behavior is not
> guaranteed, because the glibc documentation clearly states that "If
> two elements compare equal, their order after sorting is unpredictable."
>
> This patch introduces two additional sort keys to the instruction
> comparator function, making the resulting opcode table as close as
> possible to the one that would be produced by a stable sorting algorithm.
Looks sensible to me (I believe the code in question is mine).  I'm not 
sure what privs I've got for the H8 in the sim repo these days. So wait 
for other feedback rather than pushing immediately.

One class of pure formatting nit you should probably fix:


> +
> +  /* The 3rd sort key  */
> +  cmp = strcmp(p1->name, p2->name);
GNU style guidelines require a space between the function name and the 
open paren for the argument list.  The same nit appears several times in 
this patch (strlen, strchr, strncmp calls)

Jeff