From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38836 invoked by alias); 22 Nov 2016 15:21:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38819 invoked by uid 89); 22 Nov 2016 15:21:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=cagney, prep, suspected, SIM X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Nov 2016 15:21:12 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 28EEAC0528A0; Tue, 22 Nov 2016 15:21:11 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAMFL8DG030210; Tue, 22 Nov 2016 10:21:10 -0500 Subject: Re: [PATCH 02/23] Fix spelling mistakes in comments in C source files (gdb) To: Yao Qi , Ambrogino Modigliani References: <1479663498-30295-1-git-send-email-ambrogino.modigliani@mail.com> <1479663498-30295-3-git-send-email-ambrogino.modigliani@mail.com> <20161121154307.GA24810@E107787-LIN> Cc: gdb-patches@sourceware.org, ambrogino.modigliani@mail.com From: Pedro Alves Message-ID: Date: Tue, 22 Nov 2016 15:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161121154307.GA24810@E107787-LIN> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00626.txt.bz2 On 11/21/2016 03:43 PM, Yao Qi wrote: > Ambrogino doesn't have FSF copyright assignment, but I don't think > it is required in this case, because IMO, this patch is not a > "legally significant change" > https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html > and it can be regarded as "tiny change", although the patch is > not tiny, and the url above doesn't explicitly mention "fixing typo" > is not legally significant change. I agree. IANAL and all that, but IMHO there's no copyrightable content here. Two patches independently written from scratch to fix these typos would be indistinguishable. I.e., it's a mechanical change. I think we're OK. Please find a couple comments below. > --- a/gdb/cli/cli-decode.c > +++ b/gdb/cli/cli-decode.c > @@ -956,7 +956,7 @@ apropos_cmd (struct ui_file *stream, > command that requires subcommands. Also called by saying just > "help".) > > - I am going to split this into two seperate comamnds, help_cmd and > + I am going to split this into two separate comamnds, help_cmd and "commands" too, while at it. > help_list. */ > > void > --- a/gdb/arch-utils.c > +++ b/gdb/arch-utils.c > @@ -98,7 +98,7 @@ legacy_register_sim_regno (struct gdbarch *gdbarch, int regnum) > gdb_assert (regnum >= 0 && regnum < gdbarch_num_regs (gdbarch)); > /* NOTE: cagney/2002-05-13: The old code did it this way and it is > suspected that some GDB/SIM combinations may rely on this > - behavour. The default should be one2one_register_sim_regno > + behaviour. The default should be one2one_register_sim_regno We use American English spelling, so should be "behavior", I believe. > (below). */ > if (gdbarch_register_name (gdbarch, regnum) != NULL > && gdbarch_register_name (gdbarch, regnum)[0] != '\0')