Hi Mike,

On Mon, 2024-01-22 at 08:14 -0500, Mike Frysinger wrote:
> On 22 Jan 2024 13:05, Mark Wielaard wrote:
> > m32c/cpu.h defines mem as enum value, which causes GCC 14 to emit
> > 
> > sim/m32c/gdb-if.c: In function ‘sim_read’:
> > sim/m32c/gdb-if.c:162:33: error: declaration of ‘mem’ shadows a previous local [-Werror=shadow=local]
> >   162 | sim_read (SIM_DESC sd, uint64_t mem, void *buf, uint64_t length)
> >       |                        ~~~~~~~~~^~~
> > In file included from ../../binutils-gdb/sim/m32c/gdb-if.c:38:
> > sim/m32c/cpu.h:83:3: note: shadowed declaration is here
> >    83 |   mem,
> >       |   ^~~
> > 
> > Fix this by renaming mem to addr in all sim_read and sim_write functions.
> > Most already used addr instead of mem. In one file, sim/rx/gdb-if.c, this
> > also meant renaming the local addr variable to vma.
> 
> lgtm, although missing include/sim/sim.h update

Urgh, I dunno how I missed that. Pushed with include/sim/sim.h also
updated, as attached (after checking against gcc13/gcc14 it still
builds and resolves the issue).

Thanks,

Mark