From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id usMsDkdL2WT1xj8AWB0awg (envelope-from ) for ; Sun, 13 Aug 2023 17:29:43 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=wPxjqOvb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2C5911E0C2; Sun, 13 Aug 2023 17:29:43 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1A9491E028 for ; Sun, 13 Aug 2023 17:29:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8E2EF3858D37 for ; Sun, 13 Aug 2023 21:29:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8E2EF3858D37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1691962180; bh=n7zwT8PYaVqp5hb7RVzZkeZ2wbFR0HRdgd+X2dG7/3Q=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=wPxjqOvbEaTkWNLji4c9JLjRl4+H7yccKwPb8t2qVylZNy/Tau3PhCKPBT6oBM4+W tjy2z1cTuYUVyIxgHlOmD9WRveYeo0BJVvGJmpAlVKQLIAEdn7M2e3e/T8YmUa3bUj y5t2iDw3H5qjfztYI5naxFpSn/tQ1pRhpRa93Lko= Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 12CE03858D37 for ; Sun, 13 Aug 2023 21:29:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 12CE03858D37 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 134E421977; Sun, 13 Aug 2023 21:29:22 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EB3D21322C; Sun, 13 Aug 2023 21:29:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9Ip/NzFL2WT+BAAAMHmgww (envelope-from ); Sun, 13 Aug 2023 21:29:21 +0000 Message-ID: Date: Sun, 13 Aug 2023 23:29:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/symtab] Don't deduplicate variables in gdb-index Content-Language: en-US To: Kevin Buettner , Tom de Vries via Gdb-patches Cc: Tom Tromey References: <20230804173542.3357-1-tdevries@suse.de> <20230812211119.20413b22@f37-zws-nv> In-Reply-To: <20230812211119.20413b22@f37-zws-nv> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 8/13/23 06:11, Kevin Buettner wrote: > On Fri, 4 Aug 2023 19:35:42 +0200 > Tom de Vries via Gdb-patches wrote: > >> Fix this in symtab_index_entry::minimize, by not deduplicating variables. >> >> Tested on x86_64-linux, with target boards unix and cc-with-gdb-index. > > LGTM. > Hi Kevin, thanks for the review, I've pushed this after fixing a typo in the log message and a nit the updated comment. Thanks, - Tom > Reviewed-by: Kevin Buettner >