From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89588 invoked by alias); 15 Sep 2016 03:17:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88240 invoked by uid 89); 15 Sep 2016 03:17:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=H*r:112, Hx-languages-length:598 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Sep 2016 03:17:06 +0000 Received: by simark.ca (Postfix, from userid 112) id C1FB71E7DB; Wed, 14 Sep 2016 23:17:04 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id CD6EF1E13F; Wed, 14 Sep 2016 23:17:03 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 15 Sep 2016 03:17:00 -0000 From: Simon Marchi To: Tom Tromey Cc: Pedro Alves , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH master+7.12 v2 1/3] Introduce cleanup to restore current_uiout In-Reply-To: <874m5i47on.fsf@tromey.com> References: <20160914174548.5873-1-simon.marchi@ericsson.com> <20160914174548.5873-2-simon.marchi@ericsson.com> <878tuu4aje.fsf@tromey.com> <21ea4205-94b0-90a7-52f6-0014586f18a3@ericsson.com> <54b273e3-b44b-3844-695b-cfc8bf5f7026@redhat.com> <874m5i47on.fsf@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.0 X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00134.txt.bz2 On 2016-09-14 15:12, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> FWIW, I like the newer spelling better since we'll always be > Pedro> restoring current_uiout, but it's not a big deal at all. > > The only existing call to make_cleanup_restore_uiout uses > current_uiout, > so another option would be to just replace that. > > Tom Ah then it makes sense to use make_cleanup_restore_current_uiout. Why have a parametrized version when we don't need it? I'll post an updated patch.