From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34626 invoked by alias); 18 Apr 2017 20:17:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34606 invoked by uid 89); 18 Apr 2017 20:17:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=colon X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Apr 2017 20:17:20 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 214223D961; Tue, 18 Apr 2017 20:17:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 214223D961 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 214223D961 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2AE4217B49; Tue, 18 Apr 2017 20:17:19 +0000 (UTC) Subject: Re: [PATCH 1/4] Change field separator in gdbarch.sh To: Simon Marchi , gdb-patches@sourceware.org References: <20170416141430.2585-1-simon.marchi@polymtl.ca> <20170416141430.2585-2-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: Date: Tue, 18 Apr 2017 20:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170416141430.2585-2-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00526.txt.bz2 On 04/16/2017 03:14 PM, Simon Marchi wrote: > The fields in the description of the gdbarch interface are separated > using colons. That becomes a problem if we want to use things like > std::vector in it. This patch changes the field separator to use > semicolons instead. > > I think there's very little chance we'll ever want to use a semicolon in > one of the fields, but if you think another character would be more > appropriate, let me know. > > gdb/ChangeLog: > > * gdbarch.sh: Use semi-colon as field separator instead of colon. > * gdbarch.h: Re-generate. Looks like a reasonable choice. LGTM. Thanks, Pedro Alves