From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8N+PDi+s+F8fNwAAWB0awg (envelope-from ) for ; Fri, 08 Jan 2021 14:02:07 -0500 Received: by simark.ca (Postfix, from userid 112) id 378DF1E99A; Fri, 8 Jan 2021 14:02:07 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A635C1E590 for ; Fri, 8 Jan 2021 14:02:06 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DA6E538438A3; Fri, 8 Jan 2021 19:02:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DA6E538438A3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1610132525; bh=lfyFqBb9O4LDq2N5vp/0js2286edkTyF4YTx8TigzBE=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=u3gPqIerbywekzyaaQHVHzck6mCEiOmdROWUnEzxTrNiBQdAGcWTHucCTGznhE6zO 4ZdMsENNtNueHkX2fX5lSReX1hcTiF+G353EgHW7xXRkiaIwzBuMtdGkLsL0r6vjeD wBT1wU+fU6Yrd8JzdQSFchkbEkRt6FcoLbmp4e2E= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 3EC27386F83C for ; Fri, 8 Jan 2021 19:02:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3EC27386F83C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 108J1uJL031086 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 8 Jan 2021 14:02:00 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 108J1uJL031086 Received: from [10.0.0.213] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D7A241E590; Fri, 8 Jan 2021 14:01:55 -0500 (EST) Subject: Re: [PATCH v3 3/5] gdb: move commit_resume to process_stratum_target To: Andrew Burgess References: <20210108041734.3873826-1-simon.marchi@polymtl.ca> <20210108041734.3873826-4-simon.marchi@polymtl.ca> <20210108181237.GB2945@embecosm.com> Message-ID: Date: Fri, 8 Jan 2021 14:01:55 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210108181237.GB2945@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 8 Jan 2021 19:01:56 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Simon Marchi , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >> diff --git a/gdb/process-stratum-target.c b/gdb/process-stratum-target.c >> index 719167803fff..1436a550ac04 100644 >> --- a/gdb/process-stratum-target.c >> +++ b/gdb/process-stratum-target.c >> @@ -108,3 +108,26 @@ switch_to_target_no_thread (process_stratum_target *target) >> break; >> } >> } >> + >> +/* If true, `maybe_commit_resume_process_target` is a no-op. */ >> + >> +static bool defer_process_target_commit_resume; >> + >> +/* See target.h. */ > > Should be 'process-stratum-target.h' now. Fixed thanks. It would be simpler it we always wrote "See header file." :). Simon