Re: [PATCH][gdb/testsuite] Reimplement gdb.gdb/python-interrupts.exp as unittest

Tom Tromey
2021-10-19T18:12:44Z

>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:

>> +#if GDB_SELF_TEST
>> + if (selftests::hook_set_active_ext_lang)
>> + selftests::hook_set_active_ext_lang ();
>> +#endif

Tom> In particular, I'd like feedback on whether this is acceptable.

Tom> F.i., I could do instead the less intrusive (but also less flexible):

Either way is fine by me. It's clearly code just for testing purposes,
so, for me at least, I don't mind if it's too flexible or whatever.

Tom> Perhaps this could be handled using a
Tom> DEVEL_GDB_SELF_TEST, which is disabled in release branches independent
Tom> of --enable-unit-tests?

I don't really understand what you meant by this.
Do you mean having some way to disable some subset of the self-tests?
If so, I think it's fine to just have them all around.

Tom