From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id C7140388E820 for ; Wed, 17 Jun 2020 13:28:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C7140388E820 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-412-2H5WSsAXMeObE81xoB9FTg-1; Wed, 17 Jun 2020 09:28:41 -0400 X-MC-Unique: 2H5WSsAXMeObE81xoB9FTg-1 Received: by mail-wr1-f69.google.com with SMTP id c14so1175918wrw.11 for ; Wed, 17 Jun 2020 06:28:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1MfnQEtgvYtvay3JIPJEPc4/4zlziZkxotFPgB7Oonk=; b=ZlIN+w0fHqnI8e11v4trdCu51UQtiqUkGGVqlu3QnX++2048/MyOiIejGu68LVEKv3 Sgd6ebowfNmaaImyZqtl8f7uivQmL9epIjEUNtEoLOi3iTMZ3Qx3jNcpz0TKILRwDl7U 98umuZEvQbndfAW4IkaVRYwcADcxnggL2fH0vOwBRbKZLhoaha1cD33eaBVF3BW+r1HF eac70CnOh2UY2YhxhyZdW6GMF8Jn3TkiAxzTuWdDy9EXJXURniMKnLVua5hXq5ZQsTUe XSUsB56u48dWt7mj64Tkk5/5NOKEOXQ/T/u20P4ZKAmsMM2phn9I7B9+SzdWkmPmhQws VP3Q== X-Gm-Message-State: AOAM532TSteRQb3ZCsklwwVJyNQZdi5bPLmODNYmTYSsW1oyIqShyl69 jK9qSOA0OscNgMRjJk361lysGC4dyE9lKOtNQapkNOaAft9lCb6r6fUqn9Lo/C34ROpli3m97k2 6JrEM8ud94D1RRLPHZScBqw== X-Received: by 2002:adf:f611:: with SMTP id t17mr8202621wrp.69.1592400520287; Wed, 17 Jun 2020 06:28:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDgHQtKuUgj7pweej3u2BtmUZIR5BTRqIl741ibose3bjbQMQhqEJMY5hmP52X1qEP6IZydQ== X-Received: by 2002:adf:f611:: with SMTP id t17mr8202610wrp.69.1592400520139; Wed, 17 Jun 2020 06:28:40 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id z25sm402757wmf.10.2020.06.17.06.28.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2020 06:28:39 -0700 (PDT) Subject: Re: [PATCH][gdb/testsuite] Remove dependence on tcl_unknown To: Tom de Vries , gdb-patches@sourceware.org References: <20200617131855.GA1705@delia> From: Pedro Alves Message-ID: Date: Wed, 17 Jun 2020 14:28:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200617131855.GA1705@delia> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2020 13:28:44 -0000 On 6/17/20 2:18 PM, Tom de Vries wrote: > > +# Create gdb_tcl_unknown, a copy tcl's ::unknown, provided it's present as a > +# proc. > +set temp [interp create] > +if { [interp eval $temp "info procs ::unknown"] != "" } { > + set old_args [interp eval $temp "info args ::unknown"] > + set old_body [interp eval $temp "info body ::unknown"] > + eval proc gdb_tcl_unknown {$old_args} {$old_body} > +} > +interp delete $temp > +unset temp Smart. LGTM. Thanks, Pedro Alves