From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-154604-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 49057 invoked by alias); 14 Mar 2019 14:40:41 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 49045 invoked by uid 89); 14 Mar 2019 14:40:41 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:508
X-HELO: mail-wm1-f48.google.com
Received: from mail-wm1-f48.google.com (HELO mail-wm1-f48.google.com) (209.85.128.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Mar 2019 14:40:40 +0000
Received: by mail-wm1-f48.google.com with SMTP id e16so3021887wme.1        for <gdb-patches@sourceware.org>; Thu, 14 Mar 2019 07:40:40 -0700 (PDT)
Return-Path: <palves@redhat.com>
Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b])        by smtp.gmail.com with ESMTPSA id s5sm39314175wra.77.2019.03.14.07.40.37        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);        Thu, 14 Mar 2019 07:40:37 -0700 (PDT)
Subject: Re: [RFC 8.3 0/3] Some style fixes
To: Tom Tromey <tom@tromey.com>, Eli Zaretskii <eliz@gnu.org>
References: <20190308210433.32683-1-tromey@adacore.com> <83pnr08tc8.fsf@gnu.org> <83zhq26fcw.fsf@gnu.org> <874l899nh3.fsf@tromey.com> <8336ns3uv4.fsf@gnu.org> <83k1h23hat.fsf@gnu.org> <87tvg5fxzp.fsf@tromey.com>
Cc: tromey@adacore.com, gdb-patches@sourceware.org
From: Pedro Alves <palves@redhat.com>
Message-ID: <f93b619f-5a27-2771-b3d7-fa96e5e69040@redhat.com>
Date: Thu, 14 Mar 2019 14:40:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <87tvg5fxzp.fsf@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-03/txt/msg00292.txt.bz2

On 03/14/2019 12:20 PM, Tom Tromey wrote:
>>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> Eli> +#ifdef __MINGW32__
> Eli> +#include <windows.h>
> Eli> +static SHORT ncurses_norm_attr;
> Eli> +#endif
> 
> I'd somewhat prefer it if the definition were in a separate block after
> all the includes.
> 

Me too.  It would help with the "namespace gdb" effort as well,
since the variable will be braced under "namespace gdb" while
the header won't.

Thanks,
Pedro Alves