Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: fix "set scheduler-locking" thread exit hang
Date: Thu, 11 Nov 2021 19:04:39 +0000	[thread overview]
Message-ID: <f92e7cb2-f70d-42ea-230d-d223c7294f3f@palves.net> (raw)
In-Reply-To: <72158f21-42e1-6726-a311-207677da75af@efficios.com>

On 2021-11-11 18:33, Simon Marchi wrote:
> On 2021-11-11 1:09 p.m., Pedro Alves wrote:
>> On 2021-11-08 21:49, Simon Marchi via Gdb-patches wrote:
>>
>>> The problem is in handle_no_resumed: we check if some other thread is
>>> actually resumed, to see if we should ignore that event (see comments in
>>> that function for more info).  If this condition is true:
>>>
>>>     (thread->executing () || thread->has_pending_waitstatus ())
>>>
>>> ... then we ignore the event.  The problem is that there are some non-resumed
>>> threads with a pending event, which makes us ignore the event.  But these
>>> threads are not resumed, so we end up waiting while nothing executes, hence
>>> waiting for ever.
>>
>> "There are some non-resumed" ... "But these are not resumed".
>>
>> The first "non-resumed" should be "non-executing", I believe.
> 
> Hmm, no.  These other threads ("other" meaning other than the thread
> resumed under schedlock) are stopped / non-infrun-resumed.

I see, nevermind, I somehow read "non-resumed" vs "not resumed" as opposites
and then brain shorted out.  Sorry.

  reply	other threads:[~2021-11-11 19:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08 21:49 Simon Marchi via Gdb-patches
2021-11-11 18:09 ` Pedro Alves
2021-11-11 18:33   ` Simon Marchi via Gdb-patches
2021-11-11 19:04     ` Pedro Alves [this message]
2021-11-11 19:14       ` Simon Marchi via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f92e7cb2-f70d-42ea-230d-d223c7294f3f@palves.net \
    --to=pedro@palves.net \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox