From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23737 invoked by alias); 2 Dec 2016 15:04:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23707 invoked by uid 89); 2 Dec 2016 15:04:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1261 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Dec 2016 15:04:20 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0CCD114BFCE; Fri, 2 Dec 2016 15:04:19 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB2F4Fdm008570; Fri, 2 Dec 2016 10:04:15 -0500 Subject: Re: [RFA 8/8] Add constructor and destructor to demangle_parse_info To: Tom Tromey , gdb-patches@sourceware.org References: <1480395946-10924-1-git-send-email-tom@tromey.com> <1480395946-10924-9-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: Date: Fri, 02 Dec 2016 15:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1480395946-10924-9-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-12/txt/msg00092.txt.bz2 On 11/29/2016 05:05 AM, Tom Tromey wrote: > @@ -646,7 +623,8 @@ mangled_name_to_comp (const char *mangled_name, int options, > > /* If we could demangle the name, parse it to build the component > tree. */ > - info = cp_demangled_name_to_comp (demangled_name, NULL); > + std::unique_ptr info > + (cp_demangled_name_to_comp (demangled_name, NULL)); Style question: When initializing a unique_ptr from a function that returns a unique_ptr already, IMO, using = reads a little better over ()s, like: std::unique_ptr info = cp_demangled_name_to_comp (demangled_name, NULL); I.e., kind of like how you'd call make_unique with '=' instead of unique_ptr foo (make_unique()); which I've never seen. I wonder whether that's just me? > diff --git a/gdb/cp-support.h b/gdb/cp-support.h > index ca7a7d4..ffccded 100644 > --- a/gdb/cp-support.h > +++ b/gdb/cp-support.h > @@ -58,6 +58,10 @@ struct demangle_parse_info > > /* Any temporary memory used during typedef replacement. */ > struct obstack obstack; > + > + demangle_parse_info (); > + > + ~demangle_parse_info (); Put these before the data fields. Otherwise LGTM. Thanks, Pedro Alves