From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gBTRCILaiGM1Ch8AWB0awg (envelope-from ) for ; Thu, 01 Dec 2022 11:46:58 -0500 Received: by simark.ca (Postfix, from userid 112) id 21C5C1E124; Thu, 1 Dec 2022 11:46:58 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=FTt/eyG2; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CBE591E0D3 for ; Thu, 1 Dec 2022 11:46:57 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A07DE385559A for ; Thu, 1 Dec 2022 16:46:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A07DE385559A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669913216; bh=bMZG42Nes0TW4AXhB1nIdczoSm9+4Q2Ht1pw/LJcCHc=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=FTt/eyG2K/NVMP5rZ0hA97LiFRrxwNN5zLWVc/TQ/05yU4thxt4A9kNjQ6PYuIYtJ WDsA8RQ/wPyu0cW/g+reGMti4TfUnIdRux7dpKs/ePDwEqXohq+C9M5Af9qXtiuRKK czUbmggh7zvf3d4FdyC+EOuJcVvg92dUHSH568p0= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id EE009385B1AC for ; Thu, 1 Dec 2022 16:44:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EE009385B1AC Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 613271E0D3; Thu, 1 Dec 2022 11:44:58 -0500 (EST) Message-ID: Date: Thu, 1 Dec 2022 11:44:57 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] gdb/dwarf: add some QUIT macros Content-Language: fr To: Kevin Buettner , Simon Marchi via Gdb-patches Cc: Simon Marchi References: <20221201160144.1045410-1-simon.marchi@efficios.com> <20221201092742.70e5e920@f35-zws-nvidia> In-Reply-To: <20221201092742.70e5e920@f35-zws-nvidia> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 12/1/22 11:27, Kevin Buettner via Gdb-patches wrote: > On Thu, 1 Dec 2022 11:01:44 -0500 > Simon Marchi via Gdb-patches wrote: > >> While testing the fix for PR 29105, I noticed I couldn't ctrl-C my way >> out of GDB expanding many symtabs. GDB was busy in a loop in >> cooked_index_functions::expand_symtabs_matching. Add a QUIT there. I >> also happened to see a spot in >> cooked_index_functions::expand_matching_symbols where a QUIT would be >> useful too, since we iterate over a potentially big number of index >> entries and expand CUs in the loop. Add one there too. > > LGTM. > > Kevin > Thanks, pushed! Simon