From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-162194-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 88497 invoked by alias); 13 Dec 2019 17:54:44 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 88487 invoked by uid 89); 13 Dec 2019 17:54:44 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:558
X-HELO: us-smtp-delivery-1.mimecast.com
Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Dec 2019 17:54:43 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;	s=mimecast20190719; t=1576259681;	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:	 to:to:cc:mime-version:mime-version:content-type:content-type:	 content-transfer-encoding:content-transfer-encoding:	 in-reply-to:in-reply-to:references:references;	bh=5xo5sPSTVHyRtHnN37FkCjVGyDAZr2nht0tFGVvNZbc=;	b=jD5fRTP2qgqZ1SSdo7+faUWWMHz9fJdK46qoYihKMS5IqlPO2afNO2Mb5wwHZy6nHPHqrv	3SV9ombK1WjwzFH36Ox4cjoQjuo+bbuQOZ1+v18kQUfI+I2UD6HFVKQ91XMNWRHu3B2PVM	8ZOEEI4hbfuyjiJA0HVebcuf6mhRNu4=
Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-126-1xLZBXfvNWqw6beQS1SZDw-1; Fri, 13 Dec 2019 12:54:40 -0500
Received: by mail-wm1-f70.google.com with SMTP id s25so31248wmj.3        for <gdb-patches@sourceware.org>; Fri, 13 Dec 2019 09:54:40 -0800 (PST)
Return-Path: <palves@redhat.com>
Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b])        by smtp.gmail.com with ESMTPSA id x10sm10751604wrp.58.2019.12.13.09.54.38        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);        Fri, 13 Dec 2019 09:54:38 -0800 (PST)
Subject: Re: [PATCH 5/7] jit: make gdb_object::symtabs a vector of unique_ptr
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
References: <20191213060323.1799590-1-simon.marchi@polymtl.ca> <20191213060323.1799590-6-simon.marchi@polymtl.ca>
From: Pedro Alves <palves@redhat.com>
Message-ID: <f90c752f-490b-f6d8-db8e-a0ea3ee07028@redhat.com>
Date: Fri, 13 Dec 2019 17:54:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20191213060323.1799590-6-simon.marchi@polymtl.ca>
X-Mimecast-Spam-Score: 0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-12/txt/msg00602.txt.bz2

On 12/13/19 6:03 AM, Simon Marchi wrote:
>  struct gdb_object
>  {
> -  std::vector<gdb_symtab *> symtabs;
> +  std::vector<std::unique_ptr<gdb_symtab>> symtabs;
>  };

Could this be a vector or objects instead of a vector or pointers?

Like:

 std::vector<gdb_symtab> symtabs;

> +  object->symtabs.emplace_back (new gdb_symtab (file_name));
> +  return object->symtabs.back ().get ();
>  }

and:

 object->symtabs.emplace_back (file_name);
 return &object->symtabs.back ();

Thanks,
Pedro Alves