From: Pedro Alves <palves@redhat.com>
To: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>,
gdb-patches@sourceware.org
Subject: Re: [Patch v5] Add -file-list-shared-libraries MI command
Date: Fri, 17 Mar 2017 16:55:00 -0000 [thread overview]
Message-ID: <f903beee-60c7-aa40-b1f6-b5eff1006886@redhat.com> (raw)
In-Reply-To: <20170302145500.10230-1-marc-andre.laperle@ericsson.com>
On 03/02/2017 02:55 PM, Marc-Andre Laperle wrote:
> -The corresponding @value{GDBN} command is @samp{info shared}.
> +The corresponding @value{GDBN} command is @samp{info shared}. The fields
> +have a similar meaning to the @code{=library-loaded} notification.
> +The @code{ranges} field specifies the muliple segments belonging to this
Typo "muliple".
> /* Record the range of addresses belonging to this shared library.
> There may not be just one (e.g. if two segments are relocated
> - differently); but this is only used for "info sharedlibrary". */
> + differently). This is used for "info sharedlibrary" and
> + the MI command "-file-list-shared-libraries". The later has a format
Typo: "latter".
> + that supports outputting multiple segments once the related code
> + supports them. */
> CORE_ADDR addr_low, addr_high;
> };
>
Fix those, and you're good to go. Please push.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-03-17 16:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 20:28 [PATCH 1/3] Remove unused parameter in solib_add and update_solib_list Marc-Andre Laperle
2016-09-12 20:28 ` [PATCH 2/3] Add a better diagnostic message in mi_gdb_test Marc-Andre Laperle
2016-10-20 4:24 ` Simon Marchi
2016-11-23 13:03 ` Pedro Alves
2016-09-12 20:28 ` [PATCH 3/3] Add -file-list-shared-libraries MI command Marc-Andre Laperle
2016-10-14 21:20 ` Marc-André Laperle
2016-10-20 5:05 ` Simon Marchi
2016-11-23 13:06 ` Pedro Alves
2017-01-04 17:19 ` Marc-André Laperle
2017-01-12 16:15 ` Pedro Alves
2016-10-20 4:20 ` [PATCH 1/3] Remove unused parameter in solib_add and update_solib_list Simon Marchi
2016-11-23 13:03 ` Pedro Alves
2017-02-03 17:17 ` [PATCH v2 0/3] Shared libraries MI command Marc-Andre Laperle
2017-02-03 17:16 ` [PATCH v2 1/3] Remove unused parameter in solib_add and update_solib_list Marc-Andre Laperle
2017-02-03 17:16 ` [PATCH v2 2/3] Add a better diagnostic message in mi_gdb_test Marc-Andre Laperle
2017-02-03 17:16 ` [PATCH v2 3/3] Add -file-list-shared-libraries MI command Marc-Andre Laperle
2017-02-06 12:40 ` Pedro Alves
2017-02-28 22:08 ` [Patch v3] " Marc-Andre Laperle
2017-03-01 15:50 ` Marc-André Laperle
2017-03-01 16:12 ` Eli Zaretskii
2017-03-01 16:38 ` [Patch v4] " Marc-Andre Laperle
2017-03-01 17:09 ` Eli Zaretskii
2017-03-02 14:56 ` [Patch v5] " Marc-Andre Laperle
2017-03-09 19:12 ` Marc-André Laperle
2017-03-17 16:55 ` Pedro Alves [this message]
2017-03-20 19:07 ` Marc-André Laperle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f903beee-60c7-aa40-b1f6-b5eff1006886@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=marc-andre.laperle@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox