From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id TUv/Jw4y4mpYsD4AWB0awg (envelope-from ) for ; Wed, 28 Oct 2026 13:34:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1793208846; bh=bqc/j1uice8I7eBRrYW95SuphgwqNTC2Y/TmCsOMbFs=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vbcUpSxzh6gIWhjqatil/vuNJD05No9nNsbadmEVKo9P2800OmgjwoP84OvatUuvF ZnY3339BzkG/8FORIjQHsxWIv0JDepBvHvElglnhFma6ILvKWChYUE8v4zo6ctEEav HSVDb9RF6dgu9UkQMeKr57cXnldLb16S62zf914M= Received: by simark.ca (Postfix, from userid 112) id 8B3A21E007; Wed, 28 Oct 2026 13:34:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=QJsbEYEx; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7359F1E007 for ; Wed, 28 Oct 2026 13:34:05 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9ED5E4BA23CE for ; Wed, 28 Oct 2026 17:33:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9ED5E4BA23CE Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=QJsbEYEx Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 7B8154BA2E1C for ; Wed, 28 Oct 2026 17:33:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B8154BA2E1C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7B8154BA2E1C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793208814; cv=none; b=iNqnN/36dW0C8iJLRi3HKpL+k515HLr45LDRotv58lygmIIHd/yrsjH+Zse8QZylTTSgWEfJrv41Z+fhEgb9QZOUc5pHMRDr+D9B+/VwsebSK2cLwviIGmZ06XapAN2vd33My/m/ncdNzLRlA2dltxmCsTBMsFipdg10fUYXYqc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793208814; c=relaxed/simple; bh=bqc/j1uice8I7eBRrYW95SuphgwqNTC2Y/TmCsOMbFs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=HEPG0f091oiqTFfSOej17pGQZ0md7F+s+Tyq0ojMpmySnhg1hXqb5DtBrRgt5Cr5EDsPAFf2C0QE1+P6Ae/8pEhbcCesxjdXOXXOyaX/IRVzgBE2ZkSa13o2fJlV8NpQ8CSEZv3SWZNDO5IsAYQnNPTlkkyM1Z5UM8hE+qPCV9I= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=QJsbEYEx DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7B8154BA2E1C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1793208813; bh=bqc/j1uice8I7eBRrYW95SuphgwqNTC2Y/TmCsOMbFs=; h=Date:Subject:To:References:From:In-Reply-To:From; b=QJsbEYExsfGm69afUcmbn+SuFpwy+TcbZmefStylwp0sMbpkJAwYJBjS9zSaIem5C vdoJWkxLnSEiLgFIitOG5YfhgpY0JtZfWlQ094qN39YBsOwC6vEAPSP5wnd5wPPUKR DvcXi5uWzqrxAa2KYyxSo6eHcWCtQ44Uv48+NRaY= Received: by simark.ca (Postfix) id 7D0E81E007; Wed, 28 Oct 2026 13:33:32 -0400 (EDT) Message-ID: Date: Wed, 28 Oct 2026 13:33:31 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Remove #ifdef from cooked-index-entry.c To: Tom Tromey , gdb-patches@sourceware.org References: <20261028172301.1376846-1-tromey@adacore.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20261028172301.1376846-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/28/26 1:23 PM, Tom Tromey wrote: > cooked-index-entry.c has an #ifdef to work around a GCC 7.5.0 bug. > However, the workaround just removes a 'constexpr' which is not > needed. The constexpr behavior was desirable in the past, but this > changed with commit 8cbf7d2a ("gdb/dwarf: remove unnecessary > comparison in cooked_index_entry::compare"). > > This removes the #ifdef and the constexpr. Nit: it's an #if, not an #ifdef. For my curiosity, can you explain why constexpr was needed (or useful) in the first place? The commit that added it is: https://gitlab.com/gnutools/binutils-gdb/-/commit/2e724489260d02a528591eaea4710ce5aeeee0e8 but it doesn't talk about that. Approved-By: Simon Marchi Thanks, Simon