From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57678 invoked by alias); 8 Mar 2019 23:44:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57664 invoked by uid 89); 8 Mar 2019 23:43:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx2.freebsd.org Received: from mx2.freebsd.org (HELO mx2.freebsd.org) (8.8.178.116) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Mar 2019 23:43:57 +0000 Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id DAA6478417; Fri, 8 Mar 2019 23:43:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1030592150; Fri, 8 Mar 2019 23:43:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-3.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 65B2C1B21D; Fri, 8 Mar 2019 23:43:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: [PATCH 2/9] Introduce and use language_set To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20190307205709.21919-1-tom@tromey.com> <20190307205709.21919-3-tom@tromey.com> <6387c828-db23-3e49-fb76-699f5fc9e82b@FreeBSD.org> <87bm2ldm20.fsf@tromey.com> From: John Baldwin Openpgp: preference=signencrypt Message-ID: Date: Fri, 08 Mar 2019 23:44:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <87bm2ldm20.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1030592150 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.93 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.93)[-0.928,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00200.txt.bz2 On 3/8/19 2:43 PM, Tom Tromey wrote: > John> Hmm, did you consider using std::bitset for langauge_set? You'd > John> still have to write your own iterator class, so it wouldn't save much in terms > John> of lines of code. > > In this case, because there are just two spots that iterate over this > set, and because we'd need to introduce somewhat ugly casts back to > "enum language" anyway, it seemed just as good to not write an iterator > and just do this in a simpler way. Looks good to me. -- John Baldwin