From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-159592-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 71435 invoked by alias); 15 Oct 2019 15:23:16 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 71427 invoked by uid 89); 15 Oct 2019 15:23:16 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-12.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: mx1.suse.de
Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Oct 2019 15:23:15 +0000
Received: from relay2.suse.de (unknown [195.135.220.254])	by mx1.suse.de (Postfix) with ESMTP id 21697B708;	Tue, 15 Oct 2019 15:23:13 +0000 (UTC)
Subject: Re: GDB 9.1 release: Start of stabilization period ?
To: Joel Brobecker <brobecker@adacore.com>
Cc: Christian Biesinger <cbiesinger@google.com>, gdb-patches <gdb-patches@sourceware.org>
References: <20191012191938.GA2675@adacore.com> <CAPTJ0XFx7hUtjNxZLCV9OUOgMaN+fZ2-o_rHQ3sPJX4KT14rZw@mail.gmail.com> <9d160e13-fd9e-e886-2709-2a7ea29cae93@suse.de> <20191015152012.GB13252@adacore.com>
From: Tom de Vries <tdevries@suse.de>
Message-ID: <f89e3f41-a880-503f-8b1f-8d87ab308ad9@suse.de>
Date: Tue, 15 Oct 2019 15:23:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <20191015152012.GB13252@adacore.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2019-10/txt/msg00424.txt.bz2

On 15-10-2019 17:20, Joel Brobecker wrote:
>> Here's my wishlist:
>> - [gdb/tdep] Fix 'Unexpected register class' assert in
>>   amd64_push_arguments
>>   https://sourceware.org/ml/gdb-patches/2019-10/msg00293.html
> 
> Fixing asserts are always nice to have for releases :-)
> 

Yeah :)

>> - [gdb/tdep] Fix inferior call arg passing for amd64
>>   https://sourceware.org/ml/gdb-patches/2019-10/msg00307.html
>> - [gdb] Only force INTERP_CONSOLE ui_out for breakpoint commands in MI
>>   mode
>>   https://sourceware.org/ml/gdb-patches/2019-10/msg00099.html
>> - [gdb/symtab] Prefer var def over decl
>>   https://sourceware.org/ml/gdb-patches/2019-09/msg00161.html
> 
> These look fine in principle as well.
> 
> I can't review the patches in detail, but I did noticed on the last
> one that you're adding functions without adding documentation for them.
> 

Correct, Andrew also noticed that, that was fixed already and
resubmitted using Gerrit.

Thanks,
- Tom