From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79533 invoked by alias); 2 May 2017 02:44:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 78655 invoked by uid 89); 2 May 2017 02:44:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_3,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 May 2017 02:44:38 +0000 Received: by simark.ca (Postfix, from userid 33) id 8892E1E4A4; Mon, 1 May 2017 22:44:39 -0400 (EDT) To: Sergio Durigan Junior Subject: Re: [PATCH] Introduce "gdb/configure.nat" (and delete "gdb/config/*/*.mh" files) X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 02 May 2017 02:44:00 -0000 From: Simon Marchi Cc: GDB Patches , Pedro Alves In-Reply-To: <20170425202309.15771-1-sergiodj@redhat.com> References: <20170425202309.15771-1-sergiodj@redhat.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.5 X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00003.txt.bz2 > +++ b/gdb/configure.nat > @@ -0,0 +1,591 @@ > +# Copyright (C) 2013-2017 Free Software Foundation, Inc. > +# > +# This file is part of GDB. > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see > . > + > +# Variables defined here: > +# > +# NAT_FILE > +# NATDEPFILES > +# NAT_CDEPS > +# LOADLIBES > +# MH_CFLAGS > +# XM_CLIBS > +# NAT_GENERATED_FILES > +# HAVE_NATIVE_GCORE_HOST > +# NAT_EXTRA_FRAGS_FILE Could you document (if you know it) what each variable does? > +# - To avoid shell expansion of variables, declare them with single > +# quotes. > +# > +# - NAT_EXTRA_FRAGS_FILE should contain the full path of the file. > + > +case ${gdb_host_cpu} in > + aarch64) > + case ${gdb_host} in > + linux) > + # Host: AArch64 based machine running GNU/Linux > + NAT_FILE='config/nm-linux.h' > + NATDEPFILES='inf-ptrace.o fork-child.o aarch64-linux-nat.o > aarch32-linux-nat.o \ > + proc-service.o linux-thread-db.o linux-nat.o linux-fork.o \ > + linux-procfs.o linux-ptrace.o linux-osdata.o linux-waitpid.o \ > + linux-personality.o linux-namespaces.o aarch64-linux-hw-point.o \ > + aarch64-linux.o' IMO, the interest of having all of this in a single file is to be able to factor out common things. A lot of NATDEPFILES are repeated Would it be possible to have a switch on ${gdb_host} at the top level, and specify all the files specific to OSes but machine-agnostic? For example, fork-child.o and inf-ptrace.o probably appear in all the linux ports. Thanks, Simon