Re: [COMMITTED PATCH][PR gdb/25939] Move push_target call earlier in procfs.c

Pedro Alves
2020-06-22T10:19:36Z

On 6/21/20 5:37 PM, Rainer Orth wrote:
> Hi Pedro,
>
>> On 6/19/20 1:36 PM, Rainer Orth wrote:
>>>> On 6/18/20 3:55 PM, Pedro Alves via Gdb-patches wrote:
>>
>>>> Your push_target fix is still necessary, FAOD.
>>>
>>> Should I push it as is (with an appropriate description, of course) or
>>> would the code change need a comment, too?
>>
>> It's fine without a comment. I think you can remove the
>> push_target call from procfs_init_inferior at the same time,
>> too, as that one becomes unnecessary. Basically make the fix be
>> about moving the push_target call earlier.
>
> that works just fine. Here's what I've committed after testing both
> pathes together on amd64-pc-solaris2.11.

I've committed mine now.

Thanks,
Pedro Alves