From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id TNqyD9aYNWoAzw8AWB0awg (envelope-from ) for ; Fri, 19 Jun 2026 15:30:30 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=OtBp+EtG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 31F9A1E070; Fri, 19 Jun 2026 15:30:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AFE521E070 for ; Fri, 19 Jun 2026 15:30:29 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D94814BAE7E0 for ; Fri, 19 Jun 2026 19:30:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D94814BAE7E0 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=OtBp+EtG Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id C287E4BA2E0D for ; Fri, 19 Jun 2026 19:30:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C287E4BA2E0D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C287E4BA2E0D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781897402; cv=none; b=muc2G/LiBxZ0J0UpUXy9bydH6N2+lULusyPXkcmDNV8GAl4Hepy2MI8sZ2bmzB500AJPCadUDMaljFxgVBImYKqSxbNZ2b+5rHRk3EiFwGXxrVsa8fxrcM0vHKuV/nqMCaEnnny1/71YT0T0iwzSEVE6ae1bNZjDCMw6J6hEHp4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781897402; c=relaxed/simple; bh=sVPbPJMRZVuqxXQrK1ib0k7V/b9hf00f1Ct84sN6Wic=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=dm3fBrQXcHXXZ3K69606N74zjZXqjxCUkbchyEHnJxkPdImnwcmystHHufGn1CKk5ZeQjjtisJ0NIqn/UKLNLEyxHxjEMIrHOvYuC7fgT/WdVjTipHrmFSUP7MIzxjhik8sSSG0ppPcdhlkoiiZQ0/cUtoXhgn5+7b85wbgIMHs= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=OtBp+EtG DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C287E4BA2E0D Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 65JJTrv6008783 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Jun 2026 15:29:57 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 65JJTrv6008783 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1781897398; bh=Y60BjXJAqiJQrd8B4h3UWsi38Br1R2A5jOIwhPAEUe4=; h=Date:Subject:To:From:In-Reply-To:From; b=OtBp+EtGX/TGT5MtGA60pEyx1RiAqSEfFbhQ/DDP+eVKoJTyxylJ6JJ6XVsua133/ EuMgPFAcn1DbqxSTm+c/9o0Py9oFxQy7oFOoFNTT9N+pnPIJpR5ZS7S96K4PrEdzPx hVweYhBoRn2gseQ3zfNly6TKh9ERHkMvtU5yibLD55tsFhH07gnsoncO1Cs7dE2mX6 MkX5Zusw9nFlk2x12ZuwcMr5KNij8k9o4BjNm26XCsisz/YGdZc9ycwWp0AO4Px7ZA WzlJozSlgW4ZuaHZN5vWOoWHF2QDlD9DvT61QhRSuYmyjVyb51DhekESNUG/vq1Ec4 ZKCGnKzqu4X4g== Received: by simark.ca (Postfix) id E8DE41E070; Fri, 19 Jun 2026 15:29:51 -0400 (EDT) Message-ID: Date: Fri, 19 Jun 2026 15:29:51 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/7] gdb/testsuite: add -inferior-args option to runto To: "Aktemur, Baris" , "gdb-patches@sourceware.org" References: <20260506202804.1681886-1-simon.marchi@polymtl.ca> <20260506202804.1681886-4-simon.marchi@polymtl.ca> Content-Language: fr From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 19 Jun 2026 19:29:53 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/12/26 9:02 AM, Aktemur, Baris wrote: > AMD General > > Hi Simon, > >> From: Simon Marchi >> >> Add a new -inferior-args option to proc runto, to allow passing >> arguments to the test program. Its value is forwarded to gdb_run_cmd, >> which does the right thing, including with the native-gdbserver board, >> where arguments need to be passed on the gdbserver command line. >> >> The option is named -inferior-args (rather than the shorter -args) >> because parse_args sets a variable in the caller's scope using the >> option name. Naming it "-args" would clash with the "args" parameter. >> >> Subsequent patches use this new option. >> >> Change-Id: If2483c22302ed432ccd6cebef8d235e3e1d35bb8 >> --- >> gdb/testsuite/lib/gdb.exp | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp >> index 601896457fea..60bcb582aeef 100644 >> --- a/gdb/testsuite/lib/gdb.exp >> +++ b/gdb/testsuite/lib/gdb.exp >> @@ -809,6 +809,7 @@ proc runto { linespec args } { >> {no-delete-breakpoints} >> {message} >> {no-message} >> + {inferior-args ""} > > I think this needs to be documented in the proc comment. Ack, I will modify it like so: diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 31bb1c0fe59f..e9fd43aed846 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -817,16 +817,20 @@ proc gdb_breakpoint { linespec args } { # just compare to "function" because it might be a fully qualified, # single quoted C++ function specifier. # -# If there are additional arguments, pass them to gdb_breakpoint. -# We recognize -no-message/-message ourselves as well as -no-delete-breakpoints. +# This proc recognizes the -no-message/-message, -no-delete-breakpoints +# and -inferior-args options. If there are additional arguments, pass +# them to gdb_breakpoint. # # -no-message is messed up here, like gdb_breakpoint: to preserve # historical usage fails are always printed by default. # -no-message: turns off printing of fails (and passes, but they're already off) # -message: turns on printing of passes (and fails, but they're already on) # -# The 'no-delete-brekpoints' option stops this proc from deleting all +# The 'no-delete-breakpoints' option stops this proc from deleting all # breakpoints. +# +# The 'inferior-args' option allows to specify arguments to pass to the +# inferior. Simon