From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17250 invoked by alias); 6 Mar 2019 21:07:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17242 invoked by uid 89); 6 Mar 2019 21:07:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=BAYES_00,DNS_FROM_AHBL_RHSBL,RCVD_IN_DNSWL_NONE,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.1 spammy=HX-Spam-Relays-External:2001 X-HELO: mail-wm1-f65.google.com Received: from mail-wm1-f65.google.com (HELO mail-wm1-f65.google.com) (209.85.128.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Mar 2019 21:07:32 +0000 Received: by mail-wm1-f65.google.com with SMTP id z84so7255308wmg.4 for ; Wed, 06 Mar 2019 13:07:32 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id s3sm3863308wrt.81.2019.03.06.13.07.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Mar 2019 13:07:29 -0800 (PST) Subject: Re: [PATCH v2 09/22] Remove last cleanup from linux-namespaces.c To: Tom Tromey , gdb-patches@sourceware.org References: <20190227201849.32210-1-tom@tromey.com> <20190227201849.32210-10-tom@tromey.com> From: Pedro Alves Message-ID: Date: Wed, 06 Mar 2019 21:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190227201849.32210-10-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00123.txt.bz2 On 02/27/2019 08:18 PM, Tom Tromey wrote: > This removes the last cleanup from linux-namespaces.c, replacing it > with a use of SCOPE_EXIT. > > gdb/ChangeLog > 2019-02-27 Tom Tromey > > * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT. > * common/filestuff.h (make_cleanup_close): Don't declare. > * common/filestuff.c (do_close_cleanup, make_cleanup_close): > Remove. Nice. Much simpler than the previous attempts using custom RAII types. OK. Thanks, Pedro Alves