From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61342 invoked by alias); 20 Jun 2017 11:01:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58964 invoked by uid 89); 20 Jun 2017 11:01:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Jun 2017 11:01:25 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 869F3C00EB0C; Tue, 20 Jun 2017 11:01:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 869F3C00EB0C Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 869F3C00EB0C Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id E202D893F2; Tue, 20 Jun 2017 11:01:23 +0000 (UTC) Subject: Re: [PATCH 07/25] Lazily and dynamically create i386-linux target descriptions To: Yao Qi , gdb-patches@sourceware.org References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-8-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: Date: Tue, 20 Jun 2017 11:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1497256916-4958-8-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00562.txt.bz2 On 06/12/2017 09:41 AM, Yao Qi wrote: > Instead of using pre-generated target descriptions, this patch > changes GDB to lazily and dynamically create target descriptions > according to the target hardware capability (xcr0 in i386). > This support any combination of target features. > > This patch also adds a unit test to make sure dynamically generated > tdesc are identical to these generated from xml files. I don't see the unit test in the patch. Can you say something about the "regnum = %ld" change? Is it related to the rest of the patch? > > 2017-04-27 Yao Qi > > * i386-linux-tdep.c (i386_linux_read_description): Generate > target description if it doesn't exist. > [GDB_SELF_TEST] (i386_linux_read_description_test): New unit test. > (_initialize_i386_linux_tdep) [GDB_SELF_TEST]: Register unit test. Leading TAB vs spaces. > +private: > + /* The register number to use for the next register we see. */ > + int next_regnum = 0; > }; "m_" prefix. Thanks, Pedro Alves