From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by sourceware.org (Postfix) with ESMTPS id 03E943857C40 for ; Sat, 11 Jul 2020 10:50:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 03E943857C40 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wm1-f51.google.com with SMTP id j18so8607191wmi.3 for ; Sat, 11 Jul 2020 03:50:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/Sv/BsCExngemLYvzC0tJqvhEsM3E/hA7hRVPkodDMI=; b=HaY4td6Dbqs5Rd3fkhK2+IcTgQXz03r5fHRhUKsAlakVE1wSjJ51435olLHS/V/2Nr G4FwEZzKQZNibk4Sg5l49wtIEeRmvFGR4NB2iCo//wv9I3UknO/Fz46afTooGqt3aUHJ Ydn7AQzLlVHrG+BYpyp7GGOuz1gUFtvRbUoq+dR0j2F3if4RgjgYcjknfGMuNR4yuh0r 00St0Ct31Ir4U8fX1EpePLdk8N3VArqB4MJuWfosRjkVc5geelquFm8/SJ5w0OhAtAz1 zjL4pWTPXGdCig9Z8VrsCXzS/h5WO0lX3RRhuNgJqysgDO7GRcGQpXc0IPdsHmEk9JdY hTUQ== X-Gm-Message-State: AOAM531T2jGSHfEbVDFiEVikprtfqCC0tOdA0Bk78jhDUaCrPpDEIIG6 M2tJQK6hnFJngVXkVrOrF9W/yXNRq+GATQ== X-Google-Smtp-Source: ABdhPJwjL1vIKbIbTu7dG+9ub6MxTafud/69G48naaip2Y00YvMv1/cRFDWsNNY/w7TEqQgs3xcJBw== X-Received: by 2002:a7b:cd07:: with SMTP id f7mr9067612wmj.115.1594464601667; Sat, 11 Jul 2020 03:50:01 -0700 (PDT) Received: from ?IPv6:2001:8a0:f91a:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f91a:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id k11sm15745157wrd.23.2020.07.11.03.50.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Jul 2020 03:50:00 -0700 (PDT) Subject: Re: [RFAv2] Fine tune exec-file-mismatch help and documentation. To: Philippe Waroquiers , gdb-patches@sourceware.org References: <20200704142352.3533-1-philippe.waroquiers@skynet.be> From: Pedro Alves Message-ID: Date: Sat, 11 Jul 2020 11:49:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200704142352.3533-1-philippe.waroquiers@skynet.be> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jul 2020 10:50:04 -0000 On 7/4/20 3:23 PM, Philippe Waroquiers via Gdb-patches wrote: > It was deemed better to explicitly mention in help and doc that build IDs > are used for comparison, and that symbols are loaded when asking to > load the exec-file. > > This is V2, fixing 2 typos and replacing 'If the user asks to load' > by 'If the user confirms loading', as suggested by Pedro. > > gdb/ChangeLog > 2020-07-04 Philippe Waroquiers > > * exec.c (_initialize_exec): Update exec-file-mismatch help. > > gdb/doc/ChangeLog > 2020-07-04 Philippe Waroquiers > > * gdb.texinfo (Attach): Update exec-file-mismatch doc. This version LGTM. I think Eli approved the previous version so this should be good to go. Thanks, Pedro Alves