From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yLUuDfM1YWdTMB4AWB0awg (envelope-from ) for ; Tue, 17 Dec 2024 03:27:31 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=eidBGOoI; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 32D1D1E097; Tue, 17 Dec 2024 03:27:31 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C29891E05C for ; Tue, 17 Dec 2024 03:27:30 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7031F3858D20 for ; Tue, 17 Dec 2024 08:27:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7031F3858D20 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=eidBGOoI Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by sourceware.org (Postfix) with ESMTPS id 258913858C62 for ; Tue, 17 Dec 2024 08:19:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 258913858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 258913858C62 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734423558; cv=none; b=UTX+o+acA7J1X7ipriDEBmMJ032xIB4FV/bMFubPCE2Vfuojvfj/vrCscvEL4wUSinyl6ci1gSVAxSgNjsheTImu+o1oiD/X5CbQzMXEtfj/BMGa8944cAoSF8ehgOYlFFSdZHux8UnEbs9aSHEc9d+5sUTcWbq47Zu67Hr3XSE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734423558; c=relaxed/simple; bh=Rmph0Cm0dn/2wVMwVBjWRHFmHwk0iKV2VggvKtN5WNQ=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=MyMMc0jgNWnBhwFVFbFNitL1Xlvj6CL0f2UWRC5XJhMgxcDOBceQLFptVa8LeZNn0K7HkPCSCpcGSbFf52+371sN5gxYhA5kcPEF1HRX9fSaf6+gVV3Zl82hFJmGp7hUw/4azj3vO2xJhGF06LwlVpSH/x4zq3UKBYbise3sK4k= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 258913858C62 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734423558; x=1765959558; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Rmph0Cm0dn/2wVMwVBjWRHFmHwk0iKV2VggvKtN5WNQ=; b=eidBGOoI4E0zoZNI4y5j69fKnuyA0qhjYEajoIT8uE0XRG/ExyydBvvU jeMbO2xCfkVYhoP7ElXoBJum9WxM3ghr1UhWSKPkR+txE89ToXTxCJ/jJ Ig/YvCO4fj6Y+jrjcINPrzKLh+hfh2JDK4PKVm8rgzfJGo8yrOzyxevmZ qCS/4iT4vnS+jpSJ7CP8QldUyFHHAovJ3u+85FehSefnPgteQlFuyLaOB e7YRgvSAO802C4eyLOJlFRj/X3q8Rb+Nxn0mv2R0UOrLrOSz6zG1ygAZp VxcQmAqz00dBrQ0Y3uS+qpk3lDB7fV1ue1cAU+1gDxdGfGGM01tBmCy45 w==; X-CSE-ConnectionGUID: zNZZQ+9vRGidg7h6upNwYw== X-CSE-MsgGUID: NRBKUgVNTZ27CtY+dZTrsQ== X-IronPort-AV: E=McAfee;i="6700,10204,11288"; a="34160415" X-IronPort-AV: E=Sophos;i="6.12,241,1728975600"; d="scan'208";a="34160415" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2024 00:19:17 -0800 X-CSE-ConnectionGUID: U6wkuX9gTZW4XGoZ/ogA1A== X-CSE-MsgGUID: SU6uVL8cTAisQxSjDXdYUA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,241,1728975600"; d="scan'208";a="128278743" Received: from gkldtt-dev-004.igk.intel.com (HELO localhost) ([10.123.221.202]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2024 00:19:16 -0800 From: Tankut Baris Aktemur To: gdb-patches@sourceware.org Cc: simon.marchi@efficios.com Subject: [PUSHED 6/8] gdbserver: rename regcache's registers_valid to registers_fetched Date: Tue, 17 Dec 2024 09:18:28 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The registers_valid field of the regcache struct is used for tracking whether we have attempted to fetch all the registers from the target. Its name does not reflect this well, I think. It falsely gives the impression that all the registers are valid. This may conflict an individual register status, which could be REG_UNAVAILABLE. To better reflect the purpose, rename the field to "registers_fetched". Approved-By: Simon Marchi --- gdbserver/regcache.cc | 12 ++++++------ gdbserver/regcache.h | 13 +++++++------ 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc index 93bf5988a33..dad0907291b 100644 --- a/gdbserver/regcache.cc +++ b/gdbserver/regcache.cc @@ -46,7 +46,7 @@ get_thread_regcache (thread_info *thread, bool fetch) thread->set_regcache (regcache); } - if (fetch && !regcache->registers_valid) + if (fetch && !regcache->registers_fetched) { scoped_restore_current_thread restore_thread; @@ -55,7 +55,7 @@ get_thread_regcache (thread_info *thread, bool fetch) memset (regcache->register_status, REG_UNAVAILABLE, regcache->tdesc->reg_defs.size ()); fetch_inferior_registers (regcache, -1); - regcache->registers_valid = true; + regcache->registers_fetched = true; } return regcache; @@ -77,7 +77,7 @@ regcache_invalidate_thread (thread_info *thread) if (regcache == NULL) return; - if (regcache->registers_valid) + if (regcache->registers_fetched) { scoped_restore_current_thread restore_thread; @@ -85,7 +85,7 @@ regcache_invalidate_thread (thread_info *thread) store_inferior_registers (regcache, -1); } - regcache->registers_valid = false; + regcache->registers_fetched = false; } /* See regcache.h. */ @@ -146,7 +146,7 @@ init_register_cache (struct regcache *regcache, #endif } - regcache->registers_valid = false; + regcache->registers_fetched = false; return regcache; } @@ -190,7 +190,7 @@ regcache::copy_from (regcache *src) memcpy (this->register_status, src->register_status, src->tdesc->reg_defs.size ()); #endif - this->registers_valid = src->registers_valid; + this->registers_fetched = src->registers_fetched; } /* Return a reference to the description of register N. */ diff --git a/gdbserver/regcache.h b/gdbserver/regcache.h index c2e8e141d13..12345a3439c 100644 --- a/gdbserver/regcache.h +++ b/gdbserver/regcache.h @@ -33,12 +33,13 @@ struct regcache : public reg_buffer_common /* The regcache's target description. */ const struct target_desc *tdesc = nullptr; - /* Whether the REGISTERS buffer's contents are valid. If false, we - haven't fetched the registers from the target yet. Not that this - register cache is _not_ pass-through, unlike GDB's. Note that - "valid" here is unrelated to whether the registers are available - in a traceframe. For that, check REGISTER_STATUS below. */ - bool registers_valid = false; + /* Whether the REGISTERS buffer's contents are fetched. If false, + we haven't fetched the registers from the target yet. Note that + this register cache is _not_ pass-through, unlike GDB's. Also, + note that "fetched" here is unrelated to whether the registers + are available in a traceframe. For that, check REGISTER_STATUS + below. */ + bool registers_fetched = false; bool registers_owned = false; unsigned char *registers = nullptr; #ifndef IN_PROCESS_AGENT -- 2.34.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928