From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29958 invoked by alias); 30 Jan 2020 13:58:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29949 invoked by uid 89); 30 Jan 2020 13:58:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=Lukas, H*RU:sk:mail.ta, HX-Spam-Relays-External:sk:mail.ta, lukas X-HELO: mail.tachyum.com Received: from mail.tachyum.com (HELO mail.tachyum.com) (66.160.133.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Jan 2020 13:58:54 +0000 Received: by mail.tachyum.com (Postfix, from userid 1001) id A7284875; Thu, 30 Jan 2020 05:58:56 -0800 (PST) Received: from THQ-IP-EX1.tachyum.com (relayhost.tachyum.com [10.7.1.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.tachyum.com (Postfix) with ESMTPS id DC91F627; Thu, 30 Jan 2020 05:58:55 -0800 (PST) Received: from THQ-IP-EX1.tachyum.com (10.7.1.6) by THQ-IP-EX1.tachyum.com (10.7.1.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1779.2; Thu, 30 Jan 2020 05:58:45 -0800 Received: from THQ-IP-EX1.tachyum.com ([10.7.1.6]) by THQ-IP-EX1.tachyum.com ([10.7.1.6]) with mapi id 15.01.1779.007; Thu, 30 Jan 2020 05:58:45 -0800 From: Lukas Durfina To: "Aktemur, Tankut Baris" , Simon Marchi , "gdb-patches@sourceware.org" Subject: RE: [PATCH 2/2] gdb: Fix a type of sentinel Date: Thu, 30 Jan 2020 14:52:00 -0000 Message-ID: References: <20200128142830.89282-1-ldurfina@tachyum.com> <20200128142830.89282-2-ldurfina@tachyum.com> <920e08c2-dfc3-bb13-21e7-90635341df77@simark.ca> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-SW-Source: 2020-01/txt/msg00969.txt.bz2 SGVsbG8sDQoNCm51bGxwdHIgd29ya3Mgb2YgY291cnNlIHRvby4gSSB3aWxs IHByZXBhcmUgdGhlIHNlY29uZCB2ZXJzaW9uIHdpdGggbnVsbHB0ci4NCg0K VG8gU2ltb246IEkgd2lsbCBtZXJnZSBib3RoIHBhdGNoZXMgaW50byB0aGUg c2luZ2xlIG9uZS4NCkFsc28sIEkgd2lsbCB1cGRhdGUgdGhlIGNvbW1pdCBt ZXNzYWdlIGFib3V0IGZpeGVkIGNvbXBpbGF0aW9uIGVycm9yLg0KWW91IGFy ZSByaWdodCwgaXQgZml4ZXMgdGhlIGlzc3VlIGZvciBjcm9zcyBjb21waWxp bmcsIGJ1dCBmb3Igb3VyIG5ldyBhcmNoaXRlY3R1cmUgKFRhY2h5dW0pIHRo YXQgaXMgYmVpbmcgZGV2ZWxvcGVkLg0KDQpJIGFzc3VtZSB0aGUgY2hhbmdl IGlzIGdlbmVyaWMgaW1wcm92ZW1lbnQuDQoNClRoYW5rcw0KTHVrYXMNCg0K DQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEFrdGVt dXIsIFRhbmt1dCBCYXJpcyA8dGFua3V0LmJhcmlzLmFrdGVtdXJAaW50ZWwu Y29tPg0KPiBTZW50OiBUdWVzZGF5LCBKYW51YXJ5IDI4LCAyMDIwIDY6MDYg UE0NCj4gVG86IFNpbW9uIE1hcmNoaSA8c2ltYXJrQHNpbWFyay5jYT47IEx1 a2FzIER1cmZpbmENCj4gPGxkdXJmaW5hQHRhY2h5dW0uY29tPjsgZ2RiLXBh dGNoZXNAc291cmNld2FyZS5vcmcNCj4gU3ViamVjdDogUkU6IFtQQVRDSCAy LzJdIGdkYjogRml4IGEgdHlwZSBvZiBzZW50aW5lbA0KPiANCj4gT24gVHVl c2RheSwgSmFudWFyeSAyOCwgMjAyMCA1OjQ0IFBNLCBTaW1vbiBNYXJjaGkg d3JvdGU6DQo+ID4gT24gMjAyMC0wMS0yOCA5OjI4IGEubS4sIEx1a2FzIER1 cmZpbmEgd3JvdGU6DQo+ID4gPiAtLS0NCj4gPiA+ICBnZGIvQ2hhbmdlTG9n IHwgNCArKysrDQo+ID4gPiAgZ2RiL2NoYXJzZXQuYyB8IDIgKy0NCj4gPiA+ ICAyIGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlv bigtKQ0KPiA+ID4NCj4gPiA+IGRpZmYgLS1naXQgYS9nZGIvQ2hhbmdlTG9n IGIvZ2RiL0NoYW5nZUxvZyBpbmRleA0KPiA+ID4gOGI2ZGE2MmJkNC4uMWRk ODlhZTJlMCAxMDA2NDQNCj4gPiA+IC0tLSBhL2dkYi9DaGFuZ2VMb2cNCj4g PiA+ICsrKyBiL2dkYi9DaGFuZ2VMb2cNCj4gPiA+IEBAIC0xLDMgKzEsNyBA QA0KPiA+ID4gKzIwMjAtMDEtMjggTHVrYXMgRHVyZmluYSA8bGR1cmZpbmFA dGFjaHl1bS5jb20+DQo+ID4gPiArDQo+ID4gPiArCSogY2hhcnNldC5jIChm aW5kX2NoYXJzZXRfbmFtZXMpOiBGaXggYSB0eXBlIG9mIHNlbnRpbmVsLg0K PiA+ID4gKw0KPiA+ID4gIDIwMjAtMDEtMjYgIFRvbSBUcm9tZXkgIDx0b21A dHJvbWV5LmNvbT4NCj4gPiA+DQo+ID4gPiAgCSogY3RmcmVhZC5jIChzdHJ1 Y3QgY3RmX2ZwX2luZm8pOiBSZWluZGVudC4NCj4gPiA+IGRpZmYgLS1naXQg YS9nZGIvY2hhcnNldC5jIGIvZ2RiL2NoYXJzZXQuYyBpbmRleA0KPiA+ID4g NWNmZDJkODAzMC4uYWJmNzk1Y2U2ZCAxMDA2NDQNCj4gPiA+IC0tLSBhL2dk Yi9jaGFyc2V0LmMNCj4gPiA+ICsrKyBiL2dkYi9jaGFyc2V0LmMNCj4gPiA+ IEBAIC04MTgsNyArODE4LDcgQEAgZmluZF9jaGFyc2V0X25hbWVzICh2b2lk KQ0KPiA+ID4gICAgew0KPiA+ID4gICAgICBzdGQ6OnN0cmluZyBpY29udl9k aXIgPSByZWxvY2F0ZV9nZGJfZGlyZWN0b3J5IChJQ09OVl9CSU4sDQo+ID4g Pg0KPiBJQ09OVl9CSU5fUkVMT0NBVEFCTEUpOw0KPiA+ID4gLSAgICBpY29u dl9wcm9ncmFtID0gY29uY2F0IChpY29udl9kaXIuY19zdHIoKSwgU0xBU0hf U1RSSU5HLCAiaWNvbnYiLA0KPiBOVUxMKTsNCj4gPiA+ICsgICAgaWNvbnZf cHJvZ3JhbSA9IGNvbmNhdCAoaWNvbnZfZGlyLmNfc3RyKCksIFNMQVNIX1NU UklORywNCj4gPiA+ICsgImljb252IiwgKGNoYXIgKikgTlVMTCk7DQo+ID4g PiAgICB9DQo+ID4gPiAgI2Vsc2UNCj4gPiA+ICAgIGljb252X3Byb2dyYW0g PSB4c3RyZHVwICgiaWNvbnYiKTsNCj4gPiA+IC0tDQo+ID4gPiAyLjE3LjEN Cj4gPiA+DQo+ID4NCj4gPiBIaSBMdWthcywNCj4gPg0KPiA+IFNhbWUgY29t bWVudCBhcyBwYXRjaCAxLzIuDQo+ID4NCj4gPiBJZiB0aGlzIGNoYW5nZSBm aXhlcyB0aGUgc2FtZSBwcm9ibGVtIGFzIHBhdGNoIDEvMiwgdGhlbiB5b3Ug Y2FuIHB1dA0KPiA+IGJvdGggY2hhbmdlcyBpbiB0aGUgc2FtZSBwYXRjaC4N Cj4gPg0KPiA+IFNpbW9uDQo+IA0KPiBOb3cgdGhhdCB0aGUgbGluZSBpcyBi ZWluZyB0b3VjaGVkLCBpdCBtaWdodCBhbHNvIGJlIGEgZ29vZCBpZGVhIHRv IHJlcGxhY2UNCj4gTlVMTCB3aXRoIG51bGxwdHIuDQo+IA0KPiAtQmFyaXMN Cj4gDQo+IA0KPiBJbnRlbCBEZXV0c2NobGFuZCBHbWJIDQo+IFJlZ2lzdGVy ZWQgQWRkcmVzczogQW0gQ2FtcGVvbiAxMC0xMiwgODU1NzkgTmV1YmliZXJn LCBHZXJtYW55DQo+IFRlbDogKzQ5IDg5IDk5IDg4NTMtMCwgd3d3LmludGVs LmRlDQo+IE1hbmFnaW5nIERpcmVjdG9yczogQ2hyaXN0aW4gRWlzZW5zY2ht aWQsIEdhcnkgS2Vyc2hhdyBDaGFpcnBlcnNvbiBvZiB0aGUNCj4gU3VwZXJ2 aXNvcnkgQm9hcmQ6IE5pY29sZSBMYXUgUmVnaXN0ZXJlZCBPZmZpY2U6IE11 bmljaCBDb21tZXJjaWFsDQo+IFJlZ2lzdGVyOiBBbXRzZ2VyaWNodCBNdWVu Y2hlbiBIUkIgMTg2OTI4DQo= >From gdb-patches-return-163656-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Jan 30 14:52:23 2020 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 49360 invoked by alias); 30 Jan 2020 14:52:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 49352 invoked by uid 89); 30 Jan 2020 14:52:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Jan 2020 14:52:20 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 7502E203A6; Thu, 30 Jan 2020 09:52:17 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 2217220307; Thu, 30 Jan 2020 09:52:15 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 9266C20AF7; Thu, 30 Jan 2020 09:52:10 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Thu, 30 Jan 2020 14:55:00 -0000 From: "Tom de Vries (Code Review)" To: gdb-patches@sourceware.org Cc: Tankut Baris Aktemur , Mihails Strasuns , Pedro Alves Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] [gdb/threads] Fix hang in stop_all_threads after killing inferior X-Gerrit-Change-Id: Ibe1f29251fe2ff1c1991f041babbe18373c113b1 X-Gerrit-Change-Number: 759 X-Gerrit-ChangeURL: X-Gerrit-Commit: fe2db3d5c7f974e5387a3d2649e4c8f2d2a44bda In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 30 Jan 2020 09:52:10 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20200130145210.9266C20AF7@gnutoolchain-gerrit.osci.io> X-SW-Source: 2020-01/txt/msg00970.txt.bz2 Content-length: 2471 Tom de Vries has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/759 ...................................................................... Patch Set 1: > FWIW, I looked over the review comments there, and noticed the suggestion to "leave the TARGET_WAITKIND_EXITED/TARGET_WAITKIND_SIGNALLED event pending", which I tried using this additional patch: > ... > diff --git a/gdb/infrun.c b/gdb/infrun.c > index e34ddc83b45..c1035c25d7f 100644 > --- a/gdb/infrun.c > +++ b/gdb/infrun.c > @@ -4774,7 +4774,11 @@ stop_all_threads (void) > > if (event.ws.kind == TARGET_WAITKIND_SIGNALLED > && event.ws.value.sig == GDB_SIGNAL_KILL) > - goto done; > + { > + thread_info *t = find_thread_ptid (event.target, event.ptid); > + save_waitstatus (t, &event.ws); > + goto done; > + } > else if (event.ws.kind == TARGET_WAITKIND_NO_RESUMED > || event.ws.kind == TARGET_WAITKIND_THREAD_EXITED > || event.ws.kind == TARGET_WAITKIND_EXITED > ... > > But I didn't notice any difference in behaviour. I've realized from another use of save_waitstatus that I have to set t->resumed in order to have the saved wait status noticed. With this additional patch, I did manage to observe a difference in behaviour: ... @@ -4777,6 +4777,7 @@ stop_all_threads (void) { thread_info *t = find_thread_ptid (event.target, event.ptid); save_waitstatus (t, &event.ws); + t->resumed = 1; goto done; } else if (event.ws.kind == TARGET_WAITKIND_NO_RESUMED ... The difference is in what happens when I continue after the ^C is handled: - without the two patches gdb hangs, until I press enter, after which I get the prompt - with the two patches, gdb just presents the prompt -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ibe1f29251fe2ff1c1991f041babbe18373c113b1 Gerrit-Change-Number: 759 Gerrit-PatchSet: 1 Gerrit-Owner: Tom de Vries Gerrit-Reviewer: Pedro Alves Gerrit-Reviewer: Tom de Vries Gerrit-CC: Mihails Strasuns Gerrit-CC: Tankut Baris Aktemur Gerrit-Comment-Date: Thu, 30 Jan 2020 14:52:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment