From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36113 invoked by alias); 24 Jun 2019 14:13:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36104 invoked by uid 89); 24 Jun 2019 14:13:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: mail-wm1-f51.google.com Received: from mail-wm1-f51.google.com (HELO mail-wm1-f51.google.com) (209.85.128.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Jun 2019 14:13:55 +0000 Received: by mail-wm1-f51.google.com with SMTP id h19so74285wme.0 for ; Mon, 24 Jun 2019 07:13:54 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id v67sm15141008wme.24.2019.06.24.07.13.52 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 07:13:52 -0700 (PDT) Subject: Re: [PATCH 49/66] Separate out execution-info window To: Tom Tromey , gdb-patches@sourceware.org References: <20190623224329.16060-1-tom@tromey.com> <20190623224329.16060-50-tom@tromey.com> From: Pedro Alves Message-ID: Date: Mon, 24 Jun 2019 14:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190623224329.16060-50-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-06/txt/msg00530.txt.bz2 On 6/23/19 11:43 PM, Tom Tromey wrote: > + /* Get or allocate contents. */ > + tui_exec_info_content *maybe_allocate_content (int n_elements); > + > + /* Allocate contents. */ This "Allocate" here reads odd. Did you mean "Get" instead of "Allocate"? > + const tui_exec_info_content *get_content () const > + { Thanks, Pedro Alves